Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75923 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76968 invoked from network); 23 Jul 2014 08:12:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jul 2014 08:12:26 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.181 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.217.181 mail-lb0-f181.google.com Received: from [209.85.217.181] ([209.85.217.181:62688] helo=mail-lb0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9B/7F-21666-86E6FC35 for ; Wed, 23 Jul 2014 04:12:25 -0400 Received: by mail-lb0-f181.google.com with SMTP id 10so633276lbg.12 for ; Wed, 23 Jul 2014 01:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=bbLaFsMGvCjCM37ZXZlYwMWRfZtE7Vg0WKFDsN2pdYc=; b=nznX9VlBawUmWRbfRk+2zv5W6FvazOb/aaA1Eos7XZxALU/ZduiZrwe3VmXnPEGBZE 8V/aQ423ZBkEXbnsk38pPQv3pFUYr7JenuBdFmXpK32pMyIxtCBU8orHXyHhDewFKzql uX32wl2cPnPb/Ud043rRSHzwmMUrM7jbkRAwTspL3D6bDaViwi6M/qVp3TXqBrUzF2Z4 7NosGfv+iu0j1CeQAmew47lq+gSSFi4Mp2cScTKeFgrNRIb5IvuVcbz+/nz+j3Y0r7DA +mUetCy+dI/zPAKesdCO+4TR5Vh1jdizCg8OXyONBI5lBhbKeGf5CJwWAulKnwrsO7B1 Hgdg== X-Received: by 10.152.116.105 with SMTP id jv9mr13438196lab.47.1406103142981; Wed, 23 Jul 2014 01:12:22 -0700 (PDT) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.114.187.207 with HTTP; Wed, 23 Jul 2014 01:12:02 -0700 (PDT) In-Reply-To: <53CF6C1A.1020208@lsces.co.uk> References: <53CF6C1A.1020208@lsces.co.uk> Date: Wed, 23 Jul 2014 16:12:02 +0800 X-Google-Sender-Auth: WY02gy4OxJV-zeTyD9Mw0cjaVkU Message-ID: To: Lester Caine Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] phpng - loss of IS_BOOL From: laruence@php.net (Laruence) Hey: On Wed, Jul 23, 2014 at 4:02 PM, Lester Caine wrote: > I'm trying to work through some of the more subtle changes in phpng and > one that sticks out is the loss of IS_BOOL. I think the explanation is > that it removes a read, but while I'm only seeing a few uses of is_bool > across the codebase, every one of them is used simply to convert the > bool value into some other format. Surely what would make more sense > here is simply to make the type_flag either true or false, and retain > the IS_BOOL as a single identifiable type? Having two types both > indicating 'bool' just seems wrong. there is a _IS_BOOL macro to identifiable bool type.. you can use it in your own codes. thanks > > -- > Lester Caine - G8HFL > ----------------------------- > Contact - http://lsces.co.uk/wiki/?page=contact > L.S.Caine Electronic Services - http://lsces.co.uk > EnquirySolve - http://enquirysolve.com/ > Model Engineers Digital Workshop - http://medw.co.uk > Rainbow Digital Media - http://rainbowdigitalmedia.co.uk > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Laruence Xinchen Hui http://www.laruence.com/