Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75922 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75208 invoked from network); 23 Jul 2014 08:02:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jul 2014 08:02:40 -0000 Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.214 mail4-2.serversure.net Linux 2.6 Received: from [217.147.176.214] ([217.147.176.214:46956] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F2/2F-21666-D1C6FC35 for ; Wed, 23 Jul 2014 04:02:38 -0400 Received: (qmail 3533 invoked by uid 89); 23 Jul 2014 08:02:35 -0000 Received: by simscan 1.3.1 ppid: 3526, pid: 3529, t: 0.0673s scanners: attach: 1.3.1 clamav: 0.96/m:52 Received: from unknown (HELO ?10.0.0.8?) (lester@rainbowdigitalmedia.org.uk@81.138.11.136) by mail4.serversure.net with ESMTPA; 23 Jul 2014 08:02:35 -0000 Message-ID: <53CF6C1A.1020208@lsces.co.uk> Date: Wed, 23 Jul 2014 09:02:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: PHP internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: phpng - loss of IS_BOOL From: lester@lsces.co.uk (Lester Caine) I'm trying to work through some of the more subtle changes in phpng and one that sticks out is the loss of IS_BOOL. I think the explanation is that it removes a read, but while I'm only seeing a few uses of is_bool across the codebase, every one of them is used simply to convert the bool value into some other format. Surely what would make more sense here is simply to make the type_flag either true or false, and retain the IS_BOOL as a single identifiable type? Having two types both indicating 'bool' just seems wrong. -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk