Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75811
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbDxdTTuc2RpODLMY0Gu+dF=PiCux4T7U4JTh0Rqf63Eg@mail.gmail.com>
References: <CAGa2bXYP4L-EVjqiTvrOjbiRvzQJ7zyTQyu78O1AEEkk7nwEhQ@mail.gmail.com>
	<CAESVnVqBxo0VCYM_4V4_KzrD1+-F-0ipumrr_a=mAwaYje10Og@mail.gmail.com>
	<CAGa2bXa48gEEcE_DWE27B3UHD0Yi12bFVZsx-9t_anHunkj5Dg@mail.gmail.com>
	<CAHMUw2FLW06ABT=1RoH2gMuM7HbGDdSnLzxqfv8wNVp0rzfw+Q@mail.gmail.com>
	<CAGa2bXZF5sznggoYRFTtngO32b60NVG=6KqUBDB3guGb7_8oMA@mail.gmail.com>
	<CAHMUw2GyQOevKfZXuyd7S-PPUnShVVeoRvZNHK3q9w1yEe1wow@mail.gmail.com>
	<CADajX4C9sip=57QGaacZVq9cmAFhH6CJWpvSSjB7c921TGsJMQ@mail.gmail.com>
	<CAAyV7nFva4u-pW0Ago-VpkJ=-RuBvE_fjCg27Wza8_T6M0oYHA@mail.gmail.com>
	<CAGa2bXYkdBjoSpDJekPq=hxbty7GexkjyJnPNpH4vM4+v-v64Q@mail.gmail.com>
	<CAAyV7nF6HcdUcx_nYC2=87mkEGNk2AAhz3vtH9VGY0orwnzY+w@mail.gmail.com>
	<CAGa2bXaJBKL8b=ewy1VY5kWZ5G__yr=4kpJrFfxBrxr3EbntaA@mail.gmail.com>
	<CAAyV7nFE8XMgejPeRj5+ie6X+YH_w4y+Un9nksDdkqF86oo4hg@mail.gmail.com>
	<CAGa2bXaY1yq53OtpNjjgsR-7m5yMt5JYZt+kmVZoCuSkbVgUAQ@mail.gmail.com>
	<CAGa2bXaZw-V6Jc6O4ajqbnBtJsrZF9mqoZtjegdJDjBMCspmaw@mail.gmail.com>
	<A5BC162E-17A2-4C2F-BD51-AF0E399EF59B@gmail.com>
	<CAGa2bXYQ4pdv2TmujSc48R_z0jGFtO9BHPVvinmjUz+c9ZeTXw@mail.gmail.com>
	<CAGa2bXZc6OQE6umq8WjESqs5=w3XgEfKM1tV4oPeT_iMLW24cA@mail.gmail.com>
	<CAAyV7nG+Bjy2-JoUA297-FNssqOPzYa5wDfN02fy0seJkEVfug@mail.gmail.com>
	<CAGa2bXbDxdTTuc2RpODLMY0Gu+dF=PiCux4T7U4JTh0Rqf63Eg@mail.gmail.com>
Date: Tue, 22 Jul 2014 05:12:38 +0200
Message-ID: <CAEZPtU5KJy5EekvUAauhZmKrTMO4_fsAgb-qgyU8L5=n1_Dkzg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, David Muir <davidkmuir@gmail.com>, 
	Adam Harvey <aharvey@php.net>, Tjerk Meesters <tjerk.meesters@gmail.com>, 
	Sara Golemon <pollita@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] crypt() BC issue
From: pierre.php@gmail.com (Pierre Joye)

Hi Yasuo,

On Tue, Jul 22, 2014 at 5:00 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Anthony,
>
> On Mon, Jul 21, 2014 at 11:32 PM, Anthony Ferrara <ircmaxell@gmail.com>
> wrote:
>
>> > E_NOTICE for password larger than 72 is mandatory. Current
>> password_hash()
>> > works without any sign of problem even if it may not be working as
>> > authentication.
>> > I'll add E_NOTICE as bug fix if there aren't any more comments.
>>
>> Could you please not.
>>
>> I have asked you to draft an RFC to justify what you intend to do
>> (documentation, errors, etc) so that we may discuss it better. There
>> is not a single person in this thread who has said "I think a notice
>> is a good idea" except you. Yet you insist on just adding it as a "bug
>> fix". Could you please just slow down, and write out the explanations
>> so that we can have a meangingful discussion instead of just rushing
>> through to commit ignoring what everyone is saying?
>>
>
> I see you and Andrey against to have E_NOTICE for password_hash().
> There are only 2 persons to be correct. I don't know about IRC since I
> don't it at all.

I do not see any discussion about that on IRC, but I would rather not
add it either. It brings little but more confusions.

I would suggest to do what Anthony suggested and we will see the outcome.

Cheers,