Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75800
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.212.180 cause and error)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLvBRv-1AZUybnSmxG+TZwvMUth0YuDtHu2ik2k21TGJiQ@mail.gmail.com>
References: <b39ebab3d19d76cda9bafa25919c0e67@mail.gmail.com>
	<CAEZPtU52X737iUZgKUJbT0bb9z-cr_EYfxMcmv804AhnTpLnhg@mail.gmail.com>
	<CAMUwpuQrQd-ROPN0oRk37+U1JFnz487__vZxGjSC5f-TcYyfqg@mail.gmail.com>
	<2de3e71e35addbf16b2dc622f4c81eff@mail.gmail.com>
	<53CCD9BB.6060108@php.net>
	<53CCE669.8080403@beccati.com>
	<CA+9eiLvBRv-1AZUybnSmxG+TZwvMUth0YuDtHu2ik2k21TGJiQ@mail.gmail.com>
Date: Mon, 21 Jul 2014 16:19:11 +0200
Message-ID: <CAEPJdu=Zd5V_HxfKw=0YA6Wh8uHCPNSqNjuOmZWANceYEL5+PA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Matteo Beccati <php@beccati.com>, PHP Internals <internals@lists.php.net>, 
	Sebastian Bergmann <sebastian@php.net>
Content-Type: multipart/alternative; boundary=047d7b5dbcda7c72f304feb4ca6a
Subject: Re: [PHP-DEV] RFC: Move phpng to master
From: kontakt@beberlei.de (Benjamin Eberlei)

--047d7b5dbcda7c72f304feb4ca6a
Content-Type: text/plain; charset=UTF-8

On Mon, Jul 21, 2014 at 12:41 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Matteo,
>
> We have very limited forces to test everything. Once we we have bug reports
> we may look into the problems and fix them.
>

Wouldn't it be super easy to use the HHVM team infrastructure to test a
version against various PHP projects testsuites? I can't imagine it would
take longer than a few hours to adjust this to PHPs needs.


>
> Thanks. Dmitry.
>
>
> On Mon, Jul 21, 2014 at 2:07 PM, Matteo Beccati <php@beccati.com> wrote:
>
> > On 21/07/2014 11:13, Sebastian Bergmann wrote:
> > > Am 21.07.2014 10:33, schrieb Zeev Suraski:
> > >> Regarding Dmitry saying that phpng is an experimental branch - that
> was
> > a
> > >> couple of months ago.  It evolved, it runs apps in parity with 5.6,
> and
> > it's
> > >> fine to move it to master right now.  The alternative - developing 5.7
> > on
> > >> master and creating a synchronization hell - sounds like a horrible
> > course
> > >> of action.
> > >
> > >  I was not able to run PHPUnit using PHPNG at all back when it was
> first
> > >  announced.
> > >
> > >  I was able to run PHPUnit 4.3 (master)'s test suite using PHPNG last
> > >  week, btw. Only one test fails (due to a change in the output of
> > >  print_r() for SplObjectStorage IIRC). This tells me that there was a
> lot
> > >  of progress :-)
> >
> > I have temporarily re-enabled the phpng jobs on my CI server to assess
> > the current situation.
> >
> > I can confirm that just one test is failing with PHPUnit master. It
> > seems that print_r is not displaying StdClass properties as it used to:
> >
> >
> >
> https://revive.beccati.com/bamboo/browse/PHP-PHPUN-PHPNG-55/test/case/11800493
> >
> >
> > On the other hand Doctrine master can't even run the entire test suite
> > due to:
> >
> > Fatal error: Call to a member function getConfiguration() on null in
> >
> >
> /home/atlassian/bamboo/xml-data/build-dir/PHP-DOCTR-PHPNG/tests/Doctrine/Tests/OrmFunctionalTestCase.php
> > on line 482
> >
> > (pretty sure it's not a null there: a var_dump before the call tells me
> > it's an object)
> >
> > https://revive.beccati.com/bamboo/browse/PHP-DOCTR-PHPNG-52/log
> >
> >
> > The Revive Adserver test suite fails miserably (86+ out of 274 test
> > files), mostly due to errors like:
> >
> >
> >
> /home/atlassian/bamboo/xml-data/build-dir/PHP-SRC3-BUIL/Zend/zend_hash.c(1369)
> > : ht=0x29c7aa8 is already destroyed
> >
> > and some "Call to a member function" errors on object variables that are
> > mysteriously seen as null.
> >
> > https://revive.beccati.com/bamboo/browse/REV-LP-PNGP-64
> >
> > There's lots of legacy code in there and it has proved to be useful in
> > past to catch a few uncommon segmentation faults. I'm pretty sure that
> > there are plenty other applications that can't work with phpng as it is
> > now.
> >
> > To be honest I don't think we're anywhere near the point where it's safe
> > to merge phpng to master.
> >
> > Also, one thing that might have been overlooked is that merging phpng to
> > master would completely bypass the voting phase on
> > https://wiki.php.net/rfc/fast_zpp
> >
> >
> > Cheers
> > --
> > Matteo Beccati
> >
> > Development & Consulting - http://www.beccati.com/
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

--047d7b5dbcda7c72f304feb4ca6a--