Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75775
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1407211139330.3793@whisky.home.derickrethans.nl>
References: <b39ebab3d19d76cda9bafa25919c0e67@mail.gmail.com>
	<CAEZPtU52X737iUZgKUJbT0bb9z-cr_EYfxMcmv804AhnTpLnhg@mail.gmail.com>
	<CAMUwpuQrQd-ROPN0oRk37+U1JFnz487__vZxGjSC5f-TcYyfqg@mail.gmail.com>
	<CA+9eiLs3=5CF=KO7Fi28L1S1R833ZGXf0Wfr9gRZO6mCYzRamQ@mail.gmail.com>
	<alpine.DEB.2.11.1407211139330.3793@whisky.home.derickrethans.nl>
Date: Mon, 21 Jul 2014 12:44:05 +0200
Message-ID: <CAEZPtU732mLx3ynJCF9uPmp9C_+oGxtYUWPMui_4pZ9KtWFOzQ@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Dmitry Stogov <dmitry@zend.com>, Julien Pauli <jpauli@php.net>, Zeev Suraski <zeev@zend.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RFC: Move phpng to master
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Jul 21, 2014 at 12:41 PM, Derick Rethans <derick@php.net> wrote:
> On Mon, 21 Jul 2014, Dmitry Stogov wrote:
>
>> > I can only agree here.
>> >
>> > I'd like a clean API. We need to consider PHP-Next jump as an
>> > opportunity to clean our API and finally have something
>> > understandable for a newcomer, and documented. That's a move nobody
>> > dared to take in the last decade, degrading more and more our
>> > codebase in term of understandability and flexibility. This can't
>> > last
>>
>> I'm more than agree about internal cleanup. phpng benchmark results
>> proved that we take the right direction and now we implemented most
>> the ideas we had. Note that we tried not to change PHP behaviour in
>> any way. Now it's a good time to start the cleanup work.
>
> Actually, I think that should be done after merging / changing it to
> master. Right now, the phpng vs master branch differences are ... rather
> large. It'd be good to do additional cleanup in smaller chunks later on
> as it makes it a lot easier to review those changes.

Review and changes in the feature(s) branch, then propose when ready.
This is also why I asked to do so in the 1st days when phpng was
proposed: Stop adding new changes, cleanup, stabilize, propose,
continue the work. They refused it and now we should do it in the most
ugly way? Merging into master or even worst replace master with
something we have no idea about? Seriously?


-- 
Pierre

@pierrejoye | http://www.libgd.org