Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75758
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALJZF3gi8X+zpJXQFDd6=w=k=0ZbB7jnFCqsj8_9vNCb4GCiuw@mail.gmail.com>
References: <CAHWt7w2PStjm4M4XqGeQeOi=vf_e7AT7jnESzhj=W3acckUhvw@mail.gmail.com>
 <CAGa2bXbMsWfBCDF91YQ1wf=UO2Ms3VCmwQkZiOU=6yuJ_7B9mQ@mail.gmail.com> <CALJZF3gi8X+zpJXQFDd6=w=k=0ZbB7jnFCqsj8_9vNCb4GCiuw@mail.gmail.com>
Date: Mon, 21 Jul 2014 13:50:10 +0400
Message-ID: <CAHWt7w0TxPtMH9JMtDuDq==7a+4-=fAo4-1vwtvmguhD7X8S-w@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b67697c97ed5c04feb109f4
Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit
From: saprykin.dmitry@gmail.com (Dmitry Saprykin)

--047d7b67697c97ed5c04feb109f4
Content-Type: text/plain; charset=UTF-8

Ok, I will NOT ))
God saves us from bureaucracy



On 21 July 2014 13:46, Michael Wallner <mike@php.net> wrote:

>
> On 21 Jul 2014 11:24, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:
> >
> > Hi all,
> >
> > On Mon, Jul 21, 2014 at 6:12 PM, Dmitry Saprykin <
> saprykin.dmitry@gmail.com>
> > wrote:
> >
> > > Php interactive shell saves commands history when you exit it using
> 'quit'.
> > > But it throws all you history away when you exit using Ctrl+C. It is
> common
> > > practice to save history on SIGINT exit (mysql, mongo, etc.)
> > >
> > > I would like to implement SIGINT handler for interactive shell to save
> > > history on Ctrl+C exit.
> > >
> > > Threre is request on bugs.php.net for this feature
> > > https://bugs.php.net/bug.php?id=67496.
> > > I have created  pull request https://github.com/php/php-src/pull/727
> but
> > > was advised to create RFC to discuss this change.
> > >
> > > So could you provide some feedback.
> > >
> >
> > Isn't it nicer to treat this kind of change as simple bug fix/feature
> > implementation?
> > It's common behavior and there is no compatibility issue at all.
> >
>
> Yes, please do NOT create a RFC for each and every tiny feature. Just find
> someone to review and eventually merge your patch!
>

--047d7b67697c97ed5c04feb109f4--