Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75757 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67607 invoked from network); 21 Jul 2014 09:46:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2014 09:46:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender) X-PHP-List-Original-Sender: mike.php.net@gmail.com X-Host-Fingerprint: 209.85.215.42 mail-la0-f42.google.com Received: from [209.85.215.42] ([209.85.215.42:55601] helo=mail-la0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A1/53-51736-F51ECC35 for ; Mon, 21 Jul 2014 05:46:07 -0400 Received: by mail-la0-f42.google.com with SMTP id pv20so4140971lab.29 for ; Mon, 21 Jul 2014 02:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0guDG2gkJwbaTEfyaFjfBYeOQHdw/dy2myM6S/ilHXM=; b=DZmLXYYUoaPHgsEAbhKakLEIml7kbPe43yMRhFNtdZeAVHMCza0fthoNQWISAESm+E UVuRLP5kC35UDBL7O3zjqnrsdJMcFHl5ZAy+D7HIYvvNckg3Fx9HBgV0WuSlzJS9CZH0 5c8Dig7pMFBBwNHQ2sjzYNLeufr6oGjeaqEcUgj7eePeCGXxyj8xR/ScrAz2BMVSNuJR 87OE26UMGFNYYZvAi0idTbNbUpm/DX/fdCiA+KpqD5Buu6+JEVePzAtpIweJFDsDjTsa IY7lZAq5QMW1ieLMDkKKfyXTycIdJv5cLFGFg0XwLEyKkI+CIQqvZm/zHUnu6aEFhHF1 pdzQ== MIME-Version: 1.0 X-Received: by 10.152.3.65 with SMTP id a1mr9546706laa.76.1405935964141; Mon, 21 Jul 2014 02:46:04 -0700 (PDT) Sender: mike.php.net@gmail.com Received: by 10.114.27.34 with HTTP; Mon, 21 Jul 2014 02:46:04 -0700 (PDT) Received: by 10.114.27.34 with HTTP; Mon, 21 Jul 2014 02:46:04 -0700 (PDT) In-Reply-To: References: Date: Mon, 21 Jul 2014 11:46:04 +0200 X-Google-Sender-Auth: c2RCd9rSkoLFcv7HTXA6wdVlCaE Message-ID: To: Yasuo Ohgaki Cc: PHP Internals , Dmitry Saprykin Content-Type: multipart/alternative; boundary=089e0141a0a8b83f9e04feb0f95c Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit From: mike@php.net (Michael Wallner) --089e0141a0a8b83f9e04feb0f95c Content-Type: text/plain; charset=UTF-8 On 21 Jul 2014 11:24, "Yasuo Ohgaki" wrote: > > Hi all, > > On Mon, Jul 21, 2014 at 6:12 PM, Dmitry Saprykin < saprykin.dmitry@gmail.com> > wrote: > > > Php interactive shell saves commands history when you exit it using 'quit'. > > But it throws all you history away when you exit using Ctrl+C. It is common > > practice to save history on SIGINT exit (mysql, mongo, etc.) > > > > I would like to implement SIGINT handler for interactive shell to save > > history on Ctrl+C exit. > > > > Threre is request on bugs.php.net for this feature > > https://bugs.php.net/bug.php?id=67496. > > I have created pull request https://github.com/php/php-src/pull/727 but > > was advised to create RFC to discuss this change. > > > > So could you provide some feedback. > > > > Isn't it nicer to treat this kind of change as simple bug fix/feature > implementation? > It's common behavior and there is no compatibility issue at all. > Yes, please do NOT create a RFC for each and every tiny feature. Just find someone to review and eventually merge your patch! --089e0141a0a8b83f9e04feb0f95c--