Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75752 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60268 invoked from network); 21 Jul 2014 09:24:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2014 09:24:44 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.46 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.46 mail-la0-f46.google.com Received: from [209.85.215.46] ([209.85.215.46:39526] helo=mail-la0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F7/B1-51736-95CDCC35 for ; Mon, 21 Jul 2014 05:24:42 -0400 Received: by mail-la0-f46.google.com with SMTP id b8so4504142lan.5 for ; Mon, 21 Jul 2014 02:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=efl1B6PWD8Zggtvg2NKP+qY+yx/oRJH0+6pZXYkO7IY=; b=UXnIU2+kg64Lf03rVJ9mkRrS/+S6AFDxnrpTetDEk11qAnbALRLNOc3IwXeefSIIi8 570LjNkS3OmwWzc1sHmg6htaFLUuYkSA6NNUcs6/1A4S7+tLPMdMO/nlVtv5RtfAJAGf tPLYgGdNEGmYbOBRPXcZVyTrTRs2Jfm9ZmFqoZsHqzrjrptBuSXRLYWWAlR+3W8PQQB8 PDcdCLBICGHkZEX3MUe6ozaUsO+moAFDQm/0E1Gy7gl/iyPoJfRHgNlvkueXaM3uh+4L ThSNlzjNoQqqNbbsSrjbV1g+FhwN5gCrCEw7QQX4hLUBqNRn2cbj00A12teBZPzrJyUZ mbPw== X-Received: by 10.152.170.229 with SMTP id ap5mr25341918lac.12.1405934678942; Mon, 21 Jul 2014 02:24:38 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.128.202 with HTTP; Mon, 21 Jul 2014 02:23:58 -0700 (PDT) In-Reply-To: References: Date: Mon, 21 Jul 2014 18:23:58 +0900 X-Google-Sender-Auth: Ep2NgUJJfYl-tXWlNg3BPfO7jqc Message-ID: To: Dmitry Saprykin Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e011760711dabc404feb0ade9 Subject: Re: [PHP-DEV] php interactive shell: save history on SIGINT exit From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e011760711dabc404feb0ade9 Content-Type: text/plain; charset=UTF-8 Hi all, On Mon, Jul 21, 2014 at 6:12 PM, Dmitry Saprykin wrote: > Php interactive shell saves commands history when you exit it using 'quit'. > But it throws all you history away when you exit using Ctrl+C. It is common > practice to save history on SIGINT exit (mysql, mongo, etc.) > > I would like to implement SIGINT handler for interactive shell to save > history on Ctrl+C exit. > > Threre is request on bugs.php.net for this feature > https://bugs.php.net/bug.php?id=67496. > I have created pull request https://github.com/php/php-src/pull/727 but > was advised to create RFC to discuss this change. > > So could you provide some feedback. > Isn't it nicer to treat this kind of change as simple bug fix/feature implementation? It's common behavior and there is no compatibility issue at all. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --089e011760711dabc404feb0ade9--