Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75696 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77323 invoked from network); 19 Jul 2014 11:50:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jul 2014 11:50:30 -0000 Authentication-Results: pb1.pair.com header.from=narf@devilix.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=narf@devilix.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.49 as permitted sender) X-PHP-List-Original-Sender: narf@devilix.net X-Host-Fingerprint: 209.85.218.49 mail-oi0-f49.google.com Received: from [209.85.218.49] ([209.85.218.49:42323] helo=mail-oi0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8C/C0-06414-48B5AC35 for ; Sat, 19 Jul 2014 07:50:29 -0400 Received: by mail-oi0-f49.google.com with SMTP id u20so2352787oif.22 for ; Sat, 19 Jul 2014 04:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devilix.net; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WSGYfjbg4m8DhqK9O2lQ1syzakooDW+0lYYpA3bLKVU=; b=KwYWvTQYvCSXl+yhJZA72wqmU5IdNIuKY+BVTZUOavcenJqyRRRT9pIo2Ob1wIKqCK q4E/py1DdjhMFTM7BHmpjiPo2USs18QoUvpzvyxwLrpzxZULgElOR/mEPOHgWtoJxddE iwFaTt9bc70xSnya9iTIh7aNHiD6s4qK1ShtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=WSGYfjbg4m8DhqK9O2lQ1syzakooDW+0lYYpA3bLKVU=; b=YiuLyYtnLUwNDur8+7ieiVQJAT3/bFCUs5Ha6r7BHouuFrUAksiuLLyLLZx/XRHHmE igp/4HwWnM/lSC9PJ3JdgKv9zotlKrvDWGy/1nlJXV9I7S18sST52yl8nHLVbR1D9NCq 0uPtUIU4ZnbfCDHvmr6CLf22VlcLtDkVrCo6s8Dnjo4brQERdTg8NzswaXX26ZpIt4eD DollBZ6XIVWvMRW2gjU4v5UQTVWtCbkL0T+hP5doxOiVOev2y2wUDJafrPPpP8nGMJBC PXtg58Xo6tF39GzM5q93AjRxe3TOAOP9XwChv5KHZb9H0/5uaLIVY0hUd31mRWZdrykN /VWw== X-Gm-Message-State: ALoCoQlbUnQONFZjOK5WyhzoZJknt4CbLMgzQ1t8h+mG4RBLhIKo2RIfUbuunj81yiNohWDXb7S2 MIME-Version: 1.0 X-Received: by 10.60.123.103 with SMTP id lz7mr16735872oeb.18.1405770626077; Sat, 19 Jul 2014 04:50:26 -0700 (PDT) Received: by 10.202.75.205 with HTTP; Sat, 19 Jul 2014 04:50:25 -0700 (PDT) Received: by 10.202.75.205 with HTTP; Sat, 19 Jul 2014 04:50:25 -0700 (PDT) In-Reply-To: References: Date: Sat, 19 Jul 2014 14:50:25 +0300 Message-ID: To: Yasuo Ohgaki Cc: internals@lists.php.net, Nikita Popov Content-Type: multipart/alternative; boundary=047d7b5d4840cdadd904fe8a7a56 Subject: Re: [PHP-DEV] Re: crypt() BC issue From: narf@devilix.net (Andrey Andreev) --047d7b5d4840cdadd904fe8a7a56 Content-Type: text/plain; charset=UTF-8 On Jul 19, 2014 11:45 AM, "Yasuo Ohgaki" wrote: > > Hi Nikita, > > On Sat, Jul 19, 2014 at 2:46 PM, Nikita Popov wrote: > > > I'm against adding this notice to password_hash. This will require all > > applications to ensure that passwords are shorter than 72 chars. I don't > > think that's a good idea. > > > Generally speaking, it would not be serious issue. 72 bytes constant prefix > would > not be used most likely. > > However, bug like this in "authentication" code must be detected and > fixed. > If password should be truncated, it should be truncated by app developers > explicitly and > notified users that their password had been truncated. IMHO. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net Hi, There's already a notice about this in the password_hash() docs, one that almost looks like is designed to scare users, which is bad. Throwing an E_NOTICE will cause more problems than it would supposedly solve. Application developers should just state this limitation on their registration/password change pages, anything else is pointless. Cheers, Andrey. --047d7b5d4840cdadd904fe8a7a56--