Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75663
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.175 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Date: Thu, 17 Jul 2014 19:11:21 +0900
Message-ID: <CAGa2bXb0dgFfEZecTMXAJAecj0OnD-n-Hk8ucAheDvyiWZ1Wgg@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3457635bc9c04fe60dfa7
Subject: Fixing bug #66827
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c3457635bc9c04fe60dfa7
Content-Type: text/plain; charset=UTF-8

Hi all,

https://github.com/php/php-src/pull/725

This is the fix for https://bugs.php.net/bug.php?id=66827
This kind of malformed data is an attack most likely, but
raising error is not an option.

Quick grep show no module nor core log error only.
i.e. There is no error logging only code. All of them raises
E_NOTICE/E_WARNING/etc.

I would like to record a log that could be an attack.
Since there is no code like this, I ask your opinions.

The patch tries to remove offensive cookie, but it's far from
perfect. In fact, removing all of offensive cookie in session
module is impossible. We may let E_NOTICE raise and try
the best it can. If it could remove offensive cookie, error is
recorded and user may use their app from next request.

Any comments?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c3457635bc9c04fe60dfa7--