Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75658
Return-Path: <ocramius@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 49330 invoked from network); 17 Jul 2014 07:47:06 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jul 2014 07:47:06 -0000
Authentication-Results: pb1.pair.com header.from=ocramius@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=ocramius@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.53 as permitted sender)
X-PHP-List-Original-Sender: ocramius@gmail.com
X-Host-Fingerprint: 209.85.192.53 mail-qg0-f53.google.com  
Received: from [209.85.192.53] ([209.85.192.53:55203] helo=mail-qg0-f53.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 22/48-09067-87F77C35 for <internals@lists.php.net>; Thu, 17 Jul 2014 03:47:05 -0400
Received: by mail-qg0-f53.google.com with SMTP id q107so1691086qgd.12
        for <internals@lists.php.net>; Thu, 17 Jul 2014 00:47:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=fbg0mHHXIoUn7fWQEUwoe5SKO91UYf2JmReCWP9DZ1k=;
        b=w9owUMAaA3w/SVKV7XJtFgThH/04fFTvSxWAXpPfvVoO/q9N7ZlZKBa1ZtsJpcalo4
         aPr56oYb+uoYsFLAoyHO2UZGHBLAF0vxWlkcQD+TehQC6unkI//r2YIVdQYPq1OEIU2C
         MJ2p/HqwG/O9YtGeOOYVtzecvcFmLVSWh4sHNzl3zBeBssve/goYHHyH5hgQID1ymPXC
         MvOXynx9XzmjDZRTBOwKl5UnB9cBKXW36GG4b0Y76LdHoXBkaffrCxYStu0pEtl79D2I
         sLZbzvbZDTNnQ3jgZSYV7X05hRY8IF646ebVo3EBYYh95mUpZA0HZm8odtgx1tKjoyC+
         pH2g==
X-Received: by 10.140.95.101 with SMTP id h92mr54268247qge.35.1405583222733;
 Thu, 17 Jul 2014 00:47:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.21.81 with HTTP; Thu, 17 Jul 2014 00:46:42 -0700 (PDT)
In-Reply-To: <53C7709D.5060208@sugarcrm.com>
References: <CABBJUpf4Zrj+MiqGoUPp6NWBBpJzntu0NAyveZyrqx0oNQYpBA@mail.gmail.com>
 <53C75A89.5000401@fedoraproject.org> <CABBJUpfeDv1juoL=1bkaiY3M9cgLd8f6NMagSqccoQVC+vekCw@mail.gmail.com>
 <53C7685B.3040302@sugarcrm.com> <248a94f0ee70cf99ffbb0f204443ebbf@mail.gmail.com>
 <53C7709D.5060208@sugarcrm.com>
Date: Thu, 17 Jul 2014 09:46:42 +0200
Message-ID: <CADyq6sLCiZh98E8RXDvPo20ak7H7Wb5EFsQ4MvMa3UfapV8bqw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Zeev Suraski <zeev@zend.com>, Laruence <laruence@php.net>, 
	Remi Collet <remi@fedoraproject.org>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c15c50b1851b04fe5ed807
Subject: Re: [PHP-DEV] An BC issue in unserialize
From: ocramius@gmail.com (Marco Pivetta)

--001a11c15c50b1851b04fe5ed807
Content-Type: text/plain; charset=UTF-8

On Thu, Jul 17, 2014 at 8:43 AM, Stas Malyshev <smalyshev@sugarcrm.com>
wrote:

> Hi!
>
> > IMHO this isn't something we should change in a 2nd digit release, but
> on a
> > major version, even if it wasn't documented.
>
> We don't have much option here. Keeping it leads to a remote triggerable
> segfaults. We've discussed this here just recently. This is a hack that
> does not work properly with internal classes, and should not work too -
> the whole reason C: was created is because O: can not work with such
> classes.
>

As discussed in previous threads about this failure, we (doctrine) can move
away from the `unserialize()` hack if
`ReflectionClass#newInstanceWithoutConstructor()` provides support for
internal classes.

It doesn't need to cover ALL internal classes, just the most commonly
extended ones.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a11c15c50b1851b04fe5ed807--