Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75474
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.171 as permitted sender)
References: <08503591-EFC8-48E6-984E-FFC292C5EA5F@ajf.me> <alpine.DEB.2.10.1407141536380.4247@whisky.home.derickrethans.nl>
 <AF61F548-FADC-428F-B76F-1BB82C645D2C@ajf.me> <alpine.DEB.2.10.1407141552290.4247@whisky.home.derickrethans.nl>
 <6C08D5C1-7A37-4F49-BF12-96B614B4B50B@ajf.me> <8c4fa132c69f0e72d1fd963461a110c6@mail.gmail.com>
 <BB7BE5F3-ADBB-43B0-A511-6CB9CB9BD0B3@ajf.me>
In-Reply-To: <BB7BE5F3-ADBB-43B0-A511-6CB9CB9BD0B3@ajf.me>
MIME-Version: 1.0
Thread-Index: AQJuUFVOlGiX172RfpkkW7aXwqSXwwHleMkPAd/qfJcBzHP03AINxCkwAt+f6PkCKPEQC5n9DAeQ
Date: Mon, 14 Jul 2014 18:21:44 +0300
Message-ID: <01fb65fe115be4ce14cad68d3d0ad2c0@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Monday, July 14, 2014 6:12 PM
> To: Zeev Suraski
> Cc: Derick Rethans; PHP internals
> Subject: Re: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
>
>
> On 14 Jul 2014, at 16:07, Zeev Suraski <zeev@zend.com> wrote:
>
> > It does, as it creates an error (recoverable or not), and it doesn't
> > allow "13abc" to easily turn into 13 (int), even if you implement an
> > error handler that ignores E_RECOVERABLE_ERROR.
>
> Actually, you're right. In the current patch, if you run this:
>
>     set_error_handler(function () { return true; });
>     function foo(int $a) { var_dump($a); }
>     foo("13abc");
>
> You would get this:
>
>     int(0)
>
> However, that could easily be fixed so the error case uses the normal
casting
> behaviour.

Perhaps (I think it's more difficult than you think but perhaps I'm
missing something);  Either way, it's the wrong way to do it IMHO
regardless.  Having this as either a notice or a special E_CAST has no
meaningful drawbacks, only advantages, and will also enable us to
implement these warnings in regular casts for even greater consistency (a
recoverable error is out of the question for those, of course, as it's a
huge BC break).

Zeev