Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75403
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.169 as permitted sender)
References: <08503591-EFC8-48E6-984E-FFC292C5EA5F@ajf.me> <CAF+90c-ojALBgeyXu+f2tW6LoW8+4XGVpu_+i9SyX=u4RSoxug@mail.gmail.com>
 <027E65EF-C4FC-474C-92BB-D99EFADDEEED@ajf.me>
In-Reply-To: <027E65EF-C4FC-474C-92BB-D99EFADDEEED@ajf.me>
MIME-Version: 1.0
Thread-Index: AQJuUFVOlGiX172RfpkkW7aXwqSXwwOWY2SKAql1dl6aLq6DYA==
Date: Sun, 13 Jul 2014 17:31:41 +0300
Message-ID: <ada4093ad61814c182f8ca31939962ea@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>, Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
From: zeev@zend.com (Zeev Suraski)

I think this is a big step in the wrong direction to one of the most
common auto-conversion use cases out there (HTTP input variables).  See my
note to Nikita...

This RFC is a huge deal, I suggest we let more people voice their opinion
in before changing it in each direction :)

Zeev

> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Sunday, July 13, 2014 5:21 PM
> To: Nikita Popov
> Cc: PHP internals
> Subject: Re: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
>
>
> On 13 Jul 2014, at 13:09, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> > I haven't yet closely reviewed the details of what is and isn't
> > allowed, but one things I would strongly recommend against is
> > introducing any "accept but throw a notice" cases. Either a value is
allowed
> or it isn't.
> > "12foo" to an int/float argument should throw a recoverable fatal
> > error, like everything else. (I'd change that in zpp as well, but
> > that's a different discussion).
>
> I've changed this case in the RFC and my patch. Previously, "12foo"
would just
> throw an E_NOTICE, but now it is not accepted:
>
> Integer hints:
>
> function foo(int $a) {
>     var_dump($a);
> }
> foo(1); // int(1)
> foo("1"); // int(1)
> foo(1.0); // int(1)
> foo("1a"); // E_RECOVERABLE_ERROR
> foo("a"); // E_RECOVERABLE_ERROR
> foo(999999999999999999999999999999999999); //
> E_RECOVERABLE_ERROR (since it's not exactly representable by an int)
> foo(1.5); // E_RECOVERABLE_ERROR
>
> Float hints:
>
> function foo(float $a) {
>     var_dump($a);
> }
> foo(1); // float(1)
> foo("1"); // float(1)
> foo(1.0); // float(1)
> foo("1a"); // E_RECOVERABLE_ERROR
> foo("a"); // E_RECOVERABLE_ERROR
> foo(1.5); // float(1.5)
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List To unsubscribe,
visit:
> http://www.php.net/unsub.php