Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75400
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.171 as permitted sender)
References: <08503591-EFC8-48E6-984E-FFC292C5EA5F@ajf.me> <53C2178E.7070705@sugarcrm.com>
 <53C24061.6050503@lsces.co.uk> <20140713101840.GR6540@phcomp.co.uk>
 <2f218b4d8cffb1a55e464e715c319b1f@mail.gmail.com> <20140713132042.GU6540@phcomp.co.uk>
In-Reply-To: <20140713132042.GU6540@phcomp.co.uk>
MIME-Version: 1.0
Thread-Index: AQJuUFVOlGiX172RfpkkW7aXwqSXwwKNH6ZhAjN2Q/kB5EycswM8VxKBAkcM9KWZ/2eNsA==
Date: Sun, 13 Jul 2014 17:21:59 +0300
Message-ID: <3061bf696f53463cf4063ec11f71f775@mail.gmail.com>
To: Alain Williams <addw@phcomp.co.uk>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: RE: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
From: zeev@zend.com (Zeev Suraski)

> Which of the two below is clearer:
>
>     function CanDrive($age)
>     {
>         if( !is_numeric($age))
> 	    throw new Error("\$age is not integer (CanDrive())");
>
> 	return $age >= 17;
>     }
>
>     function CanDrive(int $age)
>     {
> 	return $age >= 17;
>     }

I think we're on the same page here that the 2nd one looks better, which
is the point of the RFC.

But the way I see it, the RFC should focus pretty much exclusively on
sanitizing information coming from the 'outer code' and into the 'inner
code', as opposed to enforcing strict typing within the inner code (a
function that unless I'm missing something it does not attempt to do,
thankfully).

The point of the RFC is that as the author of the API, you wouldn't have
to worry about input sanity, while still allowing the dynamic nature of
PHP - AKA type juggling - so that users who call that API don't need to be
bothered with the mechanics of their types either.

Zeev