Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75399
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <CAF+90c-ojALBgeyXu+f2tW6LoW8+4XGVpu_+i9SyX=u4RSoxug@mail.gmail.com>
Date: Sun, 13 Jul 2014 15:20:43 +0100
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <027E65EF-C4FC-474C-92BB-D99EFADDEEED@ajf.me>
References: <08503591-EFC8-48E6-984E-FFC292C5EA5F@ajf.me> <CAF+90c-ojALBgeyXu+f2tW6LoW8+4XGVpu_+i9SyX=u4RSoxug@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hinting With Casts (re-opening)
From: ajf@ajf.me (Andrea Faulds)


On 13 Jul 2014, at 13:09, Nikita Popov <nikita.ppv@gmail.com> wrote:

> I haven't yet closely reviewed the details of what is and isn't =
allowed,
> but one things I would strongly recommend against is introducing any
> "accept but throw a notice" cases. Either a value is allowed or it =
isn't.
> "12foo" to an int/float argument should throw a recoverable fatal =
error,
> like everything else. (I'd change that in zpp as well, but that's a
> different discussion).

I=92ve changed this case in the RFC and my patch. Previously, =9312foo=94 =
would just throw an E_NOTICE, but now it is not accepted:

Integer hints:

function foo(int $a) {
    var_dump($a);=20
}
foo(1); // int(1)
foo("1"); // int(1)
foo(1.0); // int(1)
foo("1a"); // E_RECOVERABLE_ERROR
foo("a"); // E_RECOVERABLE_ERROR
foo(999999999999999999999999999999999999); // E_RECOVERABLE_ERROR (since =
it's not exactly representable by an int)
foo(1.5); // E_RECOVERABLE_ERROR

Float hints:

function foo(float $a) {
    var_dump($a);=20
}
foo(1); // float(1)
foo("1"); // float(1)
foo(1.0); // float(1)
foo("1a"); // E_RECOVERABLE_ERROR
foo("a"); // E_RECOVERABLE_ERROR
foo(1.5); // float(1.5)

--
Andrea Faulds
http://ajf.me/