Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75362 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16282 invoked from network); 10 Jul 2014 18:23:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jul 2014 18:23:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.91 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.91 smtp91.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.91] ([108.166.43.91:40553] helo=smtp91.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 70/32-00135-22ADEB35 for ; Thu, 10 Jul 2014 14:23:31 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp4.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id D13911811A4; Thu, 10 Jul 2014 14:23:27 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp4.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 92FA718111C; Thu, 10 Jul 2014 14:23:24 -0400 (EDT) Message-ID: <53BEDA18.7090404@sugarcrm.com> Date: Thu, 10 Jul 2014 11:23:20 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Michael Wallner CC: Sara Golemon , Nuno Lopes , "internals@lists.php.net" References: <05091D9021CD48208FCE220DE1CCC3CE@pc07654> <53BD9F71.1090401@sugarcrm.com> <53BE5824.2020209@php.net> In-Reply-To: <53BE5824.2020209@php.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Concurrency support for run-tests From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > I added a CONCURRENCY_GROUP section, see > https://github.com/m6w6/php-src/compare/parallel-run-tests?expand=1 > > If the next test to execute is in the same CONCURRENCY_GROUP as one > which is already/still running, it will be pushed back. > > So tests with f.e. listening servers could use "port:9999" as > CONCURRENCY_GROUP or mysql tests could use "mysql:dbname", etc. As > example, I added the open_basedir tests to one group because they all > tamper around with the same subdirectories. The problem there is that for a lot of tests the dependency is in common include file (like server.inc or connect.inc) and extracting it into the main file may be a bit time-consuming and also means we'd have to keep the information in sync in many places at once. > I also added a shuffle($test_files) if $concurrency is greater than 2 > because that helps running the test suite concurrently actually. > Anybody got an idea why the tests are sorted at all? To have a predictable order and reproducible test runs? Imagine we have an inadvertent test dependency, in which test X fails after test Y is run. If the order is stable, it is relatively easy to discover. If it is random, reproducing the exact test alignment which caused the failure is next to impossible. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/