Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75202 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86070 invoked from network); 3 Jul 2014 08:24:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2014 08:24:44 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.107 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.107 smtp107.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.107] ([108.166.43.107:38092] helo=smtp107.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 21/59-47713-B4315B35 for ; Thu, 03 Jul 2014 04:24:43 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp6.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 52D268054B; Thu, 3 Jul 2014 04:24:40 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp6.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 8829E812FD; Thu, 3 Jul 2014 04:24:39 -0400 (EDT) Message-ID: <53B51347.30405@sugarcrm.com> Date: Thu, 03 Jul 2014 01:24:39 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tjerk Meesters , Solar Designer CC: Ferenc Kovacs , Adam Harvey , Andrea Faulds , PHP internals , D0znpp References: <20140703003646.GA12662@openwall.com> <53B4AC6E.5050401@sugarcrm.com> <20140703012402.GA13015@openwall.com> <20140703060837.GB16494@openwall.com> <20140703063713.GA16777@openwall.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] multiline HTTP headers support in header() From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Or, check for NUL byte first and reject the whole thing if present; then > continue with `strpbrk()` :) To check for nul, you need to scan the whole string. If you're already doing this, you don't need strpbrk anymore. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/