Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75198 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63355 invoked from network); 3 Jul 2014 06:45:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2014 06:45:56 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.115 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.115 smtp115.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.115] ([108.166.43.115:39569] helo=smtp115.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 48/F4-47713-32CF4B35 for ; Thu, 03 Jul 2014 02:45:56 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp7.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 6A7823817EE; Thu, 3 Jul 2014 02:45:53 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp7.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id C514538179B; Thu, 3 Jul 2014 02:45:52 -0400 (EDT) Message-ID: <53B4FC1F.4080608@sugarcrm.com> Date: Wed, 02 Jul 2014 23:45:51 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Adam Harvey , Solar Designer CC: Andrea Faulds , PHP internals , D0znpp References: <20140703003646.GA12662@openwall.com> <53B4AC6E.5050401@sugarcrm.com> <20140703012402.GA13015@openwall.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] multiline HTTP headers support in header() From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > I'd tend to agree: if we're going to do this, let's just rip the > band-aid off completely. I've got a quick and dirty patch at > https://github.com/LawnGnome/php-src/compare/remove-multiline-headers?expand=1 > that does this, and applies cleanly against every branch from 5.4 to > master. This doesn't look correct - strpbrk will stop at nul bytes, but there's no guarantee the actual SAPI would. Also no reason to delete so many tests - some of them tests for other things than multiline headers too. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/