Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75157
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <53B1590F.5070009@gmail.com>
References: <CAHMUw2EohSiEszkxER4CsR9L0FWz=P9audQ5o6WxLpn4KQjXfA@mail.gmail.com>
	<679D0316-74C5-4AEC-9097-5E9793937469@ajf.me>
	<53B1590F.5070009@gmail.com>
Date: Mon, 30 Jun 2014 16:25:49 -0700
Message-ID: <CAKOpQSw16jVjbFE471A4DBZg5Sr2ONsge_y1zRHPNeO1pORtOg@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c246e6ba4aa104fd15fadf
Subject: Re: [PHP-DEV] Re: ucwords() vs title case
From: kris.craig@gmail.com (Kris Craig)

--001a11c246e6ba4aa104fd15fadf
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 30, 2014 at 5:33 AM, Rowan Collins <rowan.collins@gmail.com>
wrote:

> Andrea Faulds wrote (on 30/06/2014):
>
>> On 30 Jun 2014, at 12:54, Tjerk Meesters <tjerk.meesters@gmail.com>
>> wrote:
>>
>>  Hi internals,
>>>
>>> I came across this old bug: https://bugs.php.net/bug.php?id=3D34407
>>>
>>>
>>>
>>> Personally I find that the latter is too much of a departure from what =
we
>>> currently have; a compromise could be to treat punctuation as a word
>>> delimiter.
>>>
>> Hmm. Why not make it follow what \b in a regex would do, looking for
>> =E2=80=9Cword boundaries=E2=80=9D?
>>
>
> Unfortunately, the cleverer you try to be, the more edge cases you find.
> For instance, using \b will capitalise the 's' after an apostrophe, e.g. =
in
> "Andrea'S Suggestion".
>
> The function we have in our code base at the moment looks like this:
>
> function smart_uc_words($string)
> {
>         $string =3D strtolower(trim($string));
>         // Capitalise any word char preceded by a non-word char other tha=
n
> an apostrophe
>         $string =3D preg_replace_callback('/(?<!\w|\')(\w)/', function($m=
){
> return strtoupper($m[1]); }, $string);
>         // Capitalise any word char which comes between an apostrophe and
> another word char
>         $string =3D preg_replace_callback('/(?<=3D\')(\w)(?=3D\w)/',
> function($m){ return strtoupper($m[1]); }, $string);
>
>         return $string;
> }
>

What about leaving the default behavior as-is but adding an optional
argument to specify how to determine these boundaries?  So if you did
something like ucwords( "hello, world!", '\b' ) or ucwords( "hello,
world!", array( ' ', '.', ... ) ), the user could control the behavior
while existing ucwords( $arg ) code would behave as it does now without any
BC.

--Kris

--001a11c246e6ba4aa104fd15fadf--