Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75106
Return-Path: <dz@heroku.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 16889 invoked from network); 26 Jun 2014 20:30:50 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Jun 2014 20:30:50 -0000
Authentication-Results: pb1.pair.com smtp.mail=dz@heroku.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=dz@heroku.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain heroku.com designates 209.85.160.49 as permitted sender)
X-PHP-List-Original-Sender: dz@heroku.com
X-Host-Fingerprint: 209.85.160.49 mail-pb0-f49.google.com  
Received: from [209.85.160.49] ([209.85.160.49:56587] helo=mail-pb0-f49.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 45/60-11209-8F28CA35 for <internals@lists.php.net>; Thu, 26 Jun 2014 16:30:49 -0400
Received: by mail-pb0-f49.google.com with SMTP id rr13so3591923pbb.36
        for <internals@lists.php.net>; Thu, 26 Jun 2014 13:30:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:content-type:mime-version:subject:from
         :in-reply-to:date:cc:content-transfer-encoding:message-id:references
         :to;
        bh=rxLz86X5WpsLYS2eUVFk9NJaUzEieHx0+lEJxbzRjns=;
        b=Y8KlKn1oj3CXHOCZQRMyNGUm1m8MDoY4t51Dim7zV4cdtQIB5RnhbBQwyUasXOLWss
         kTN4TCLdGdj1S36O2S1WNwb88AmHV8LVJGsnsBYzDIhNwt90WD50biSzsMfpFBqTDFK+
         ku+LHZtiyc/elVDFdNKB07UWVsFQ/+iW3Jq/t4V1FUVr0L0Zu8tEvg2cIKAHOH1Ss/84
         QEacrF/sb4XQvWjvgQNjY9Cl213cZAbivjR7ejV9W8VC/9KZ+TVbocOG2JFuopqF/VbE
         PtsBTyo3OlMyC26gUgmrNmc/K0N4Q75dyeDmDHFwb/Kb3NDwkV7LY1FkseSCemnhg/UY
         ZwyQ==
X-Gm-Message-State: ALoCoQkCCt+wf8JNO4XFvqZ18JJS0YQToG2q35mpUxoyvnYNZGgBqtQ2Sd5DxBfMWcIfEJNeq51z
X-Received: by 10.68.193.164 with SMTP id hp4mr24371259pbc.87.1403814646466;
        Thu, 26 Jun 2014 13:30:46 -0700 (PDT)
Received: from ?IPv6:2600:1010:b022:e383:872:4c9a:6b88:9e07? ([2600:1010:b022:e383:872:4c9a:6b88:9e07])
        by mx.google.com with ESMTPSA id ih6sm11410079pbc.22.2014.06.26.13.30.44
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Thu, 26 Jun 2014 13:30:45 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
In-Reply-To: <CAEZPtU4c2R-0kgiy+QtMDwY0pmKRomUpWGtg18uHrBKOzS+4OQ@mail.gmail.com>
Date: Thu, 26 Jun 2014 13:19:48 -0700
Cc: Stas Malyshev <smalyshev@sugarcrm.com>,
 Julien Pauli <jpauli@php.net>,
 Ilia Alshanetsky <ilia@prohost.org>,
 Ferenc Kovacs <tyra3l@gmail.com>,
 tony@daylessday.org,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <8332CA5A-A255-4222-8C06-303813653CB4@heroku.com>
References: <035C7115-6871-4FC6-802E-464FD48070EF@heroku.com> <CAH-PCH4TWkYUE3EN8JmLByVZB-Y3OB1b5izeYGtJXbgBNBN2dw@mail.gmail.com> <CAMUwpuTerXZb68mqbzRDeozgnW-BOauamsVmFfn6cJMxQ5PJGg@mail.gmail.com> <CAEZPtU6QG6Si9oetv29Ot_uXmCmmQynE4=vb--oA1QBGqSM7CA@mail.gmail.com> <1C110716-6C9D-4EB8-97BA-2CEABE2C4847@heroku.com> <5A82BEA2-7D25-46B8-BFFF-6EB368B46190@heroku.com> <9A3A1383-B237-46FE-977B-A191A76C650A@heroku.com> <CAH-PCH6SNmm1=7oJ8H_+h+qouCC3F=cF3TKCfHydZkRaoR49og@mail.gmail.com> <CAMUwpuQa2n+Y0xjhidOp1nBc68cZucVv53JiJkMBkDAMeBO4Jg@mail.gmail.com> <CAH-PCH65MPsmf4yc0jo4hTujMXjMyWxuuRJWik8XnVYJZvYE2A@mail.gmail.com> <53AC5D29.3010707@sugarcrm.com> <CAMUwpuSmhRzXhJz36KkrkY_4W75Q-mEbG=_wxNKPnyVqDoBviQ@mail.gmail.com> <C6688AC9-B10C-433C-B78E-9EFE3A1212CA@heroku.com> <CAEZPtU4c2R-0kgiy+QtMDwY0pmKRomUpWGtg18uHrBKOzS+4OQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
X-Mailer: Apple Mail (2.1510)
Subject: Re: [PHP-DEV] Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM
From: dz@heroku.com (David Zuelke)

On 26.06.2014, at 12:23, Pierre Joye <pierre.php@gmail.com> wrote:

> On Jun 26, 2014 9:12 PM, "David Zuelke" <dz@heroku.com> wrote:
> >
>=20
> > That's what RCs are for, right? :)
>=20
> In an ideal world with ideal users yes.
>=20
> But we are not in that world :)

I know :)

For e.g. https://bugs.php.net/bug.php?id=3D65641 I realize it's =
difficult to judge the potential impact; I've hit many different =
variations of (F)CGI env vars, and it's one big mess where you pull on =
one end and it collapses on the other.

The PR I'm suggesting however is not in the complicated =
fix_pathinfo/apache_was_here nightmare section of the code and thus =
straightforward enough to evaluate.

Plus, it very obviously doesn't belong there in the first place. It =
fixes an issue that can't even occur with FastCGI, and as a result =
(because the if() is very "generic" and "aggressive" in how it tries to =
"detect" a certain situation), it breaks other config combinations, such =
as the new SetHandler based Apache FastCGI proxying.

David