Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75104
Return-Path: <dz@heroku.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 7313 invoked from network); 26 Jun 2014 19:12:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Jun 2014 19:12:40 -0000
Authentication-Results: pb1.pair.com header.from=dz@heroku.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=dz@heroku.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain heroku.com designates 209.85.160.49 as permitted sender)
X-PHP-List-Original-Sender: dz@heroku.com
X-Host-Fingerprint: 209.85.160.49 mail-pb0-f49.google.com  
Received: from [209.85.160.49] ([209.85.160.49:51833] helo=mail-pb0-f49.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 30/59-39155-6A07CA35 for <internals@lists.php.net>; Thu, 26 Jun 2014 15:12:38 -0400
Received: by mail-pb0-f49.google.com with SMTP id rr13so3493784pbb.8
        for <internals@lists.php.net>; Thu, 26 Jun 2014 12:12:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:content-type:mime-version:subject:from
         :in-reply-to:date:cc:content-transfer-encoding:message-id:references
         :to;
        bh=sLiynzVPEOUKkB4wEZrl8Y8774+tNJsMzNfouVg5H+4=;
        b=G72a+IcJZcbuQtiOzF/vJ9EC3Pt3BL+JfMYBrr37U3tTYHNyKq/+LDMW4+AXk8WrCi
         pjJjdkQH4eyhSd8+81byt09qPDVP1gpRlnLZrpIltDQ9jLi0TOUTRsWcnqKSd/j3vqqu
         PVdlIYK7OImhsovefueM1ba+dBz2r0py4uj1T+i/NaMwnQX6m6NpPY7nAGSaHsWxnKZO
         e9MVM2vZsRrdJcMJXfUecGKC8TrX+YooQBG9Q6In8Oe/aoudEQ5ZcLEbgWd+n6ZpEPA2
         EQ2hPs5pPcGm1F62x2p1w0lkZPYwqex9Tt8scMIYSj9eWuNM4HpViidJ+VyOmDD69w00
         F6WQ==
X-Gm-Message-State: ALoCoQlOaUaZ/GuYv2uwQ30pJFwUNJctfj6i5h65OFD03tjZtiCEuptpyGV1Rls9zrOvB31Mfc92
X-Received: by 10.68.176.5 with SMTP id ce5mr20360675pbc.93.1403809954893;
        Thu, 26 Jun 2014 12:12:34 -0700 (PDT)
Received: from [10.0.0.103] ([162.217.74.156])
        by mx.google.com with ESMTPSA id qf10sm11248835pbc.23.2014.06.26.12.12.33
        for <multiple recipients>
        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
        Thu, 26 Jun 2014 12:12:34 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
In-Reply-To: <CAMUwpuSmhRzXhJz36KkrkY_4W75Q-mEbG=_wxNKPnyVqDoBviQ@mail.gmail.com>
Date: Thu, 26 Jun 2014 12:12:31 -0700
Cc: Stas Malyshev <smalyshev@sugarcrm.com>,
 Ferenc Kovacs <tyra3l@gmail.com>,
 Ilia Alshanetsky <ilia@prohost.org>,
 Pierre Joye <pierre.php@gmail.com>,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C6688AC9-B10C-433C-B78E-9EFE3A1212CA@heroku.com>
References: <035C7115-6871-4FC6-802E-464FD48070EF@heroku.com> <CAH-PCH4TWkYUE3EN8JmLByVZB-Y3OB1b5izeYGtJXbgBNBN2dw@mail.gmail.com> <CAMUwpuTerXZb68mqbzRDeozgnW-BOauamsVmFfn6cJMxQ5PJGg@mail.gmail.com> <CAEZPtU6QG6Si9oetv29Ot_uXmCmmQynE4=vb--oA1QBGqSM7CA@mail.gmail.com> <1C110716-6C9D-4EB8-97BA-2CEABE2C4847@heroku.com> <5A82BEA2-7D25-46B8-BFFF-6EB368B46190@heroku.com> <9A3A1383-B237-46FE-977B-A191A76C650A@heroku.com> <CAH-PCH6SNmm1=7oJ8H_+h+qouCC3F=cF3TKCfHydZkRaoR49og@mail.gmail.com> <CAMUwpuQa2n+Y0xjhidOp1nBc68cZucVv53JiJkMBkDAMeBO4Jg@mail.gmail.com> <CAH-PCH65MPsmf4yc0jo4hTujMXjMyWxuuRJWik8XnVYJZvYE2A@mail.gmail.com> <53AC5D29.3010707@sugarcrm.com> <CAMUwpuSmhRzXhJz36KkrkY_4W75Q-mEbG=_wxNKPnyVqDoBviQ@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>,
 tony@daylessday.org
X-Mailer: Apple Mail (2.1510)
Subject: Re: [PHP-DEV] Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM
From: dz@heroku.com (David Zuelke)

On 26.06.2014, at 11:19, Julien Pauli <jpauli@php.net> wrote:

> On Thu, Jun 26, 2014 at 7:49 PM, Stas Malyshev =
<smalyshev@sugarcrm.com> wrote:
>> Hi!
>>=20
>>> ops, sorry I have missinterpreted your previous mail.
>>> having it in 5.4 would of course better.
>>>=20
>>> Stas are you ok with merging this to PHP-5.4 now?
>>=20
>> I'm ok with it. Did you ping Jerome Loyet or Antony? They are listed =
as
>> maintainers, haven't heard from them on that.
>=20
> As Pierre said : are we absolutely sure about this patch ?
>=20
> History shows that we once failed at patching FPM and introduced =
problems.

That's what RCs are for, right? :)

It's a relatively straightforward change, and you can see from a look at =
http://github.com/php/php-src/pull/694 and =
https://github.com/dzuelke/php-src/blob/apache_fcgi_sethandler/sapi/cgi/cg=
i_main.c#L1205 that the code that the change removes was simply a =
verbatim copy from the old CGI code that didn't get cleaned up during =
the "translation" to FPM.

In a FastCGI environment, SCRIPT_FILENAME and SCRIPT_NAME cannot contain =
the name of the PHP executable, as that's not known or invoked by the =
web server, so the code is completely redundant.

CCing Antony so he can confirm/approve.

David

P.S. Just to emphasize this again: we're running this in production for =
all PHP customers now with zero issues, running a standard FPM config =
and the usual Apache config; tested with ProxyPassMatch, mod_rewrite and =
the new (Apache 2.4.10) SetHandler way of connecting the two. The first =
two suffer from https://bugs.php.net/bug.php?id=3D65641, so that should =
be addressed too, eventually.