Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75083 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29113 invoked from network); 26 Jun 2014 01:00:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Jun 2014 01:00:16 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.99 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.99 smtp99.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.99] ([108.166.43.99:44221] helo=smtp99.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AC/50-26264-F907BA35 for ; Wed, 25 Jun 2014 21:00:15 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp13.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 1E06A380994; Wed, 25 Jun 2014 21:00:13 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp13.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id BCFF4380A73; Wed, 25 Jun 2014 21:00:12 -0400 (EDT) Message-ID: <53AB709C.1000809@sugarcrm.com> Date: Wed, 25 Jun 2014 18:00:12 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Marco Pivetta CC: Nikita Nefedov , "internals@lists.php.net" References: <53A1C722.9060501@fedoraproject.org> <53A21137.6010705@sugarcrm.com> <53A2A9BD.1070603@sugarcrm.com> <53A3874E.20704@sugarcrm.com> <53A65578.6000701@sugarcrm.com> <53A8626B.701@fedoraproject.org> <53A866B6.4060501@sugarcrm.com> <53A92B24.40706@fedoraproject.org> <53A92F93.2060507@sugarcrm.com> <53A9CC06.5060707@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Bug 67072 resolution for 5.4/5.5 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > You keep mentioning these two, but don't they assume that the serialized > data is user-provided? Yes, they do. > I don't think anybody sane would/should do that in first place, as it Simple search on github suggests otherwise. > would be already possible to cause RCE just with any class implementing > the `Serializable` interface. Not sure how you could do that, could you please explain how would you cause that? > I see RCEs anywhere user input is used to dynamically instantiate > anything as well, I just think that it is not the case here, as it would > be the developer's fault for granting access to serialized data to the user. I'm not sure what is the problem with simple instantiation - of course, this runs the ctor and unserialize methods, but those are supposed to be able to handle external data. I was, of course, speaking of running arbitrary code on C level, not just PHP methods purposed to handle the data by the developers. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/