Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75071
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLuM2VfYssk0z7KEqffoh8fwZ1bNR+bFFtTviKa_UMWhZQ@mail.gmail.com>
References: <CAH-PCH6EZBhoYXNk8z_LP7AGxSjiVQVrZeQ2VhwmXuCp4C3ySA@mail.gmail.com>
	<CA+9eiLuM2VfYssk0z7KEqffoh8fwZ1bNR+bFFtTviKa_UMWhZQ@mail.gmail.com>
Date: Wed, 25 Jun 2014 16:32:10 +0200
Message-ID: <CAH-PCH4=PmhLzbQYRwZBx=XZWZSw7TKiGaGstdKjyqf2bcL=0Q@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@php.net>
Content-Type: multipart/alternative; boundary=001a1133453c0ad6e104fca9f1eb
Subject: Re: why do we not set http 500 for errors when the display_error is enabled
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a1133453c0ad6e104fca9f1eb
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 25, 2014 at 3:30 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> We can't set 500 response code if HTTP headers were already sent.
>

we have the !SG(headers_sent) check for that, and I'm not proposing to
remove that(albeit I think that we could handle the special scenario, when
the only output is generated by the error, but that is a separate topic).


>
> We also don't set 500 response code if display_error is "on", because
> browsers won't show the actual page with error message (may be it was jus=
t
> IE6 or below and it's not a problem anymore).
>

I see. I assume this is related to http://support.microsoft.com/kb/294807
where by default IE shows pretty but generic message for non-2xx messages
if the response content length is less than or equal to a specific
threshold(512 bytes for 500 errors for example).
I don't think that it was a good idea to patch our error handling for the
sake of an usability feature only present in one browser.

thanks for the explanation!

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a1133453c0ad6e104fca9f1eb--