Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75067
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.182 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <CAH-PCH6SNmm1=7oJ8H_+h+qouCC3F=cF3TKCfHydZkRaoR49og@mail.gmail.com>
References: <035C7115-6871-4FC6-802E-464FD48070EF@heroku.com>
 <CAH-PCH4TWkYUE3EN8JmLByVZB-Y3OB1b5izeYGtJXbgBNBN2dw@mail.gmail.com>
 <CAMUwpuTerXZb68mqbzRDeozgnW-BOauamsVmFfn6cJMxQ5PJGg@mail.gmail.com>
 <CAEZPtU6QG6Si9oetv29Ot_uXmCmmQynE4=vb--oA1QBGqSM7CA@mail.gmail.com>
 <1C110716-6C9D-4EB8-97BA-2CEABE2C4847@heroku.com> <5A82BEA2-7D25-46B8-BFFF-6EB368B46190@heroku.com>
 <9A3A1383-B237-46FE-977B-A191A76C650A@heroku.com> <CAH-PCH6SNmm1=7oJ8H_+h+qouCC3F=cF3TKCfHydZkRaoR49og@mail.gmail.com>
Date: Wed, 25 Jun 2014 11:12:31 +0200
Message-ID: <CAMUwpuQa2n+Y0xjhidOp1nBc68cZucVv53JiJkMBkDAMeBO4Jg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: David Zuelke <dz@heroku.com>, Ilia Alshanetsky <ilia@prohost.org>, Pierre Joye <pierre.php@gmail.com>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM
From: jpauli@php.net (Julien Pauli)

On Wed, Jun 25, 2014 at 12:55 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
> Julien, do you have any problem merging this PR to PHP-5.5(and merging
> upwards) so it can be released with 5.5.15 (and with 5.6.0RC2)?

Don't we take 5.4 as basis ?

Julien


>
>
> On Wed, Jun 25, 2014 at 12:15 AM, <dz@heroku.com> wrote:
>>
>> The change is now in Apache 2.4.x
>> (http://svn.apache.org/viewvc?view=3Drevision&revision=3D1604378) and th=
ey're
>> planning a release soon:
>> http://thread.gmane.org/gmane.comp.apache.devel/53822
>>
>> Can someone please at least merge the pull request? Would be a shame IMO
>> if this didn't make it into 5.6.0.
>>
>> I'll gladly provide docs for this, too.
>>
>> David
>>
>>
>> On 20.06.2014, at 07:11, dz@heroku.com wrote:
>>
>> > Bump?
>> >
>> > We've been running http://github.com/php/php-src/pull/694 in productio=
n
>> > at Heroku for a while now, with no issues.
>> >
>> > I really think this should be in 5.6, too. It'll make setting up PHP-F=
PM
>> > so much less painful on Apache once their new release is out.
>> >
>> > And if someone could also please review and commit
>> > https://bugs.php.net/bug.php?id=3D65641 (or find a better way; I'll be=
 glad to
>> > help with anything like setting up Apache accordingly etc), then even =
with
>> > current versions of Apache, PHP will finally work fine. Currently, qui=
te a
>> > few frameworks etc that use (or rewrite to) PATH_INFO are plainly brok=
en.
>> >
>> > Thanks,
>> >
>> > David
>> >
>> >
>> > On 17.06.2014, at 14:33, David Zuelke <dz@heroku.com> wrote:
>> >
>> >> On 13.06.2014, at 17:19, Pierre Joye <pierre.php@gmail.com> wrote:
>> >>
>> >>> On Fri, Jun 13, 2014 at 9:30 AM, Julien Pauli <jpauli@php.net> wrote=
:
>> >>>> On Thu, Jun 12, 2014 at 10:11 PM, Ferenc Kovacs <tyra3l@gmail.com>
>> >>>> wrote:
>> >>>>>>
>> >>>>>> Could we still squeeze this fix into 5.2.14? I know you just roll=
ed
>> >>>>>> RC1
>> >>>>>> (while I was fiddling with this stuff), but it would be so, so hu=
ge
>> >>>>>> to have
>> >>>>>> this in=E2=80=A6 or at least in 5.2.15.
>> >>>>>>
>> >>>>>
>> >>>>> just to prevent confusion, you meant 5.5.14 and 5.5.15 here.
>> >>>>
>> >>>> Obviously 5.5.X yes.
>> >>>>
>> >>>> I myself answered that I dont see any criticity to roll out an RC2
>> >>>> for
>> >>>> 5.5.14, just for this specific bug.
>> >>>> I think it can go to 5.5.15 or any version as far as the patch is
>> >>>> tested and merged up.
>> >>>
>> >>> Given the security issues fixes waiting to be released, I would not
>> >>> delay the releases any longer.
>> >>
>> >> So, who wants to merge the PR? :)
>> >>
>> >> And if someone could review and possibly apply any of the
>> >> https://bugs.php.net/bug.php?id=3D65641 attachments that'd be great t=
oo,
>> >> although I suspect that it's possible to fix the problem way further =
up in
>> >> the code so that this stripping of stuff isn't even necessary at such=
 a
>> >> "late" stage.
>> >>
>> >> With those two out of the way, PHP-FPM and Apache will be a lot, lot
>> >> easier to set up together. One bit of config, done.
>> >>
>> >> David
>> >>
>> >> P.S. would be great for 5.4 too I think, not just 5.5+!
>> >>
>> >>
>> >
>>
>
>
>
> --
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu