Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75052 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56518 invoked from network); 23 Jun 2014 17:41:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2014 17:41:15 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.99 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.99 smtp99.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.99] ([108.166.43.99:34132] helo=smtp99.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/A0-51283-9B668A35 for ; Mon, 23 Jun 2014 13:41:14 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp5.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 46EC6181A52; Mon, 23 Jun 2014 13:41:11 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp5.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id ED17D18109F; Mon, 23 Jun 2014 13:41:10 -0400 (EDT) Message-ID: <53A866B6.4060501@sugarcrm.com> Date: Mon, 23 Jun 2014 10:41:10 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Remi Collet , PHP Internals References: <53A1C722.9060501@fedoraproject.org> <53A21137.6010705@sugarcrm.com> <53A2A9BD.1070603@sugarcrm.com> <53A3874E.20704@sugarcrm.com> <53A65578.6000701@sugarcrm.com> <53A8626B.701@fedoraproject.org> In-Reply-To: <53A8626B.701@fedoraproject.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Bug 67072 resolution for 5.4/5.5 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Minimal reproducer: > > class FooFile extends SplFileInfo { > } > $str = 'O:7:"FooFile":0:{}'; > var_dump(unserialize($str)); > ?> I'm afraid here we can't do much - SplFileInfo is one of the classes that it is unsafe to instantiate this way. It's what original 67072 was about and I don't think it's safe to leave it this way, since at best it can crash any code that uses unserialize() on external data, at worst you got RCE. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227