Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75040 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99042 invoked from network); 23 Jun 2014 00:20:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2014 00:20:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.83 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.83 smtp83.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.83] ([108.166.43.83:55660] helo=smtp83.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EB/B0-25208-3D277A35 for ; Sun, 22 Jun 2014 20:20:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp19.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 47A3C1806DF; Sun, 22 Jun 2014 20:20:33 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp19.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id A8A1918077F; Sun, 22 Jun 2014 20:20:32 -0400 (EDT) Message-ID: <53A772D0.3010404@sugarcrm.com> Date: Sun, 22 Jun 2014 17:20:32 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Ferenc Kovacs CC: Sebastian Bergmann , Julien Pauli , Remi Collet , PHP Internals References: <53A1C722.9060501@fedoraproject.org> <53A21137.6010705@sugarcrm.com> <53A2A9BD.1070603@sugarcrm.com> <53A3874E.20704@sugarcrm.com> <53A65578.6000701@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: Bug 67072 resolution for 5.4/5.5 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > for the issue to materialize you need to feed hand-crafted input to > unserialize, True. > anybody doing that with user controlled data already asking > for problems, True in theory, in practice this is widely and commonly done. > I prefer this over what we have in 5.4/5.5 and given how few classes > does 1, actually mean, I think it would be an acceptable compromise, but > let's hear what others think. Cool, waiting for others to chime in. > ps: I've seen that you created a pull request with the patch, if > somebody don't wanna copypaste the patch from the mail, here it is: > https://github.com/php/php-src/pull/701 Yes, thanks for quoting it, it seems to be green on Travis and phpunit also seems to work fine with it. I also added a unit tests with a couple of cases to see how it's supposed to work. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227