Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75030 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13471 invoked from network); 21 Jun 2014 19:57:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jun 2014 19:57:31 -0000 Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 192.64.116.216 imap10-3.ox.privateemail.com Received: from [192.64.116.216] ([192.64.116.216:37276] helo=imap10-3.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 56/E0-06324-AA3E5A35 for ; Sat, 21 Jun 2014 15:57:31 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id 268672400D2; Sat, 21 Jun 2014 15:57:28 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap10.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap10.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id W_2UTi2WsG6G; Sat, 21 Jun 2014 15:57:28 -0400 (EDT) Received: from [192.168.0.15] (unknown [90.210.122.167]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 95E3C2400DE; Sat, 21 Jun 2014 15:57:26 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) In-Reply-To: Date: Sat, 21 Jun 2014 20:57:23 +0100 Cc: PHP Internals Content-Transfer-Encoding: quoted-printable Message-ID: <2823D158-6DCA-4021-9A5C-9E2CBFE3AC95@ajf.me> References: To: Tjerk Meesters X-Mailer: Apple Mail (2.1878.2) Subject: Re: [PHP-DEV] [DRAFT][RFC] Big Integer Support From: ajf@ajf.me (Andrea Faulds) On 20 Jun 2014, at 17:47, Tjerk Meesters = wrote: > Regarding the pow() operator, if both operands are IS_LONG it does = multiplications if the exponent is positive; I don't see that logic = repeated in the IS_BIGINT cases. Was that causing issues? That=92s because I modified the existing code which manually computed = pow() for two ints and overflowed to float, by simply making it overflow = to bigint instead. The IS_BIGINT cases use the zend_bigint pow functions = instead. >=20 > Also, I noticed a couple of merge commits on your branch that you may = wish to iron out :) > =20 I ought to, but that would mean rewriting history, and I=92d rather not = do that in case it breaks some fork or what have you. I actually have an = abandoned fork of my own bigint branch which does bitwise ops = differently, though I don=92t care for it. Maybe, if this eventually is = merged into phpng, I could rebase them out then. -- Andrea Faulds http://ajf.me/