Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:7503 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86499 invoked by uid 1010); 3 Feb 2004 10:29:03 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 86419 invoked from network); 3 Feb 2004 10:29:02 -0000 Received: from unknown (HELO mwinf0801.wanadoo.fr) (193.252.22.23) by pb1.pair.com with SMTP; 3 Feb 2004 10:29:02 -0000 Received: from legolas.laposte.net (AMontsouris-108-1-18-79.w80-15.abo.wanadoo.fr [80.15.147.79]) by mwinf0801.wanadoo.fr (SMTP Server) with ESMTP id B56981800139 for ; Tue, 3 Feb 2004 11:29:01 +0100 (CET) Message-ID: <6.0.1.1.0.20040203110602.01aee3c0@pop.laposte.net> X-Sender: e.colinet@pop.laposte.net (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1 Date: Tue, 03 Feb 2004 11:27:08 +0100 To: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=====================_8295187==_" Subject: Php version header sent when no_headers is set From: e.colinet@laposte.net (Eric Colinet) --=====================_8295187==_ Content-Type: text/plain; charset="us-ascii"; format=flowed Hi, The Php version header line (SAPI_PHP_VERSION_HEADER) is sent even if SG(request_info).no_headers==1 (in php_request_startup - all other headers aren't sent) Attached a little patch that fix that. Eric Ps: @echo ON ;-) --=====================_8295187==_ Content-Type: text/plain; charset="us-ascii" Content-Disposition: attachment; filename="main_c_version_header.txt" Index: main.c =================================================================== RCS file: /repository/php-src/main/main.c,v retrieving revision 1.587 diff -u -3 -r1.587 main.c --- main.c 29 Jan 2004 00:08:21 -0000 1.587 +++ main.c 3 Feb 2004 10:04:02 -0000 @@ -1062,7 +1062,7 @@ zend_set_timeout(PG(max_input_time)); } - if (PG(expose_php)) { + if (PG(expose_php) && SG(request_info).no_headers) { sapi_add_header(SAPI_PHP_VERSION_HEADER, sizeof(SAPI_PHP_VERSION_HEADER)-1, 1); } --=====================_8295187==_--