Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:75014 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90427 invoked from network); 20 Jun 2014 00:58:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jun 2014 00:58:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.91 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.91 smtp91.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.91] ([108.166.43.91:50525] helo=smtp91.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DF/B5-61414-25783A35 for ; Thu, 19 Jun 2014 20:58:58 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp12.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 8187D8079C; Thu, 19 Jun 2014 20:58:55 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp12.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id E938480C94; Thu, 19 Jun 2014 20:58:54 -0400 (EDT) Message-ID: <53A3874E.20704@sugarcrm.com> Date: Thu, 19 Jun 2014 17:58:54 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Marco Pivetta , Ferenc Kovacs CC: Julien Pauli , Remi Collet , PHP Internals References: <53A1C722.9060501@fedoraproject.org> <53A21137.6010705@sugarcrm.com> <53A2A9BD.1070603@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > Wouldn't it be much easier to just revert for 5.4 and 5.5 and then > patching `ReflectionClass#newInstanceWithoutConstructor()` to just > handle internal PHP classes as well? We can not just handle internal PHP classes without calling their ctor. That's the whole problem - for internal class, if ctor is not called, you can get segfault on anything you do with the class. > Is there a technical limitation for this? > Are there security problems related to the patch that broke > phpunit/doctrine? If not, can the patch simply be delayed and only > applied to 5.6? Right now we know this thing can produce segfaults. But running code on unititialized data may be worse than that. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227