Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:75011
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH5-vtCVvGvceMqt6rDXq4zo0Vb34cyDK3KdBUNfg_oLyg@mail.gmail.com>
References: <CAH-PCH6xEXspisLOHtiTbViA4vDTk7q6LM3t_Bh9Dzr1cj_Nag@mail.gmail.com>
 <53A1C722.9060501@fedoraproject.org> <53A21137.6010705@sugarcrm.com>
 <CAMUwpuT_S2EE6cdJM95RzY4vmORGx3vJ9+gau8G3EZCMsNSydA@mail.gmail.com>
 <53A2A9BD.1070603@sugarcrm.com> <CAH-PCH5-vtCVvGvceMqt6rDXq4zo0Vb34cyDK3KdBUNfg_oLyg@mail.gmail.com>
Date: Fri, 20 Jun 2014 02:45:20 +0200
Message-ID: <CADyq6sKQbV+Avzfs3OAdGM9Hc85i18t0LSATD6Rk=HjqKOMgBg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Julien Pauli <jpauli@php.net>, 
	Remi Collet <remi@fedoraproject.org>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c13cca10763604fc39d0ad
Subject: Re: [PHP-DEV] Re: Problems with the fix for the BC break introduced
 in 5.4.29 and 5.5.13
From: ocramius@gmail.com (Marco Pivetta)

--001a11c13cca10763604fc39d0ad
Content-Type: text/plain; charset=UTF-8

On 20 June 2014 02:30, Ferenc Kovacs <tyra3l@gmail.com> wrote:

> I've linked the discussion and provide a really compact summary (I think it
> is too compact) at https://bugs.php.net/bug.php?id=67072
> I'm a bit indecisive about the current situation, because I think that we
> should fix the root cause of these problems, but I'm also wanna make sure
> that we don't totally criple phpunit-mock-objects and doctrine with a micro
> release.
>


At the end of the day, what we need is just instantiating an object without
invoking its constructor.

Wouldn't it be much easier to just revert for 5.4 and 5.5 and then patching
`ReflectionClass#newInstanceWithoutConstructor()` to just handle internal
PHP classes as well?
Is there a technical limitation for this?
Are there security problems related to the patch that broke
phpunit/doctrine? If not, can the patch simply be delayed and only applied
to 5.6?

If we get a stable API to instantiate objects in our way, we'd simply
gradually move away from the reflection "hack" in the next point releases
of doctrine/phpunit, while using `unserialize()` only for older versions of
PHP.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a11c13cca10763604fc39d0ad--