Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74976
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.197 cause and error)
Message-ID: <53A1C722.9060501@fedoraproject.org>
Date: Wed, 18 Jun 2014 19:06:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
References: <CAH-PCH6xEXspisLOHtiTbViA4vDTk7q6LM3t_Bh9Dzr1cj_Nag@mail.gmail.com>
In-Reply-To: <CAH-PCH6xEXspisLOHtiTbViA4vDTk7q6LM3t_Bh9Dzr1cj_Nag@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Problems with the fix for the BC break introduced in 5.4.29 and
 5.5.13
From: remi@fedoraproject.org (Remi Collet)

Le 17/06/2014 16:05, Ferenc Kovacs a =C3=A9crit :
> Hi,
>=20
> Could you check out my last mail about the unserialize stuff?:
> http://news.php.net/php.internals/74947

The initial commit try to fix a segfault for bug #67072.

	https://bugs.php.net/67072

This case is really awful... something which should not exists.

Ok, a segfault is bad, but we have live with it since years.

My proposal, for a quick solution, trying to be pragmatic and
trying to make the most of php users happy.

Revert in 5.4.30 to the 5.4.28 code (only var_serialize.* + tests)
Revert in 5.5.14 to the 5.5.12 code

This should allow to release without new delay.

In 5.6+ (or master), keep the fix
(don't allow to unserialize things which don't have to be)

And allow newInstanceWithoutConstructor for internal classes.
(make this unserialize hack used by phpunit and doctrine unneeded)

And fix classes which need to be fixed.


Remi.