Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74898
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <53999376.8070807@fedoraproject.org>
References: <53999376.8070807@fedoraproject.org>
Date: Sat, 14 Jun 2014 09:40:19 +0200
Message-ID: <CAH-PCH6Ooj3v2uA0Svk11hRgirutGsz3UtfOKRWfJ_joebJDyA@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: PHP internals <internals@lists.php.net>, Sebastian Bergmann <sebastian@php.net>
Content-Type: multipart/alternative; boundary=001a113a73a2e9b6af04fbc6e7b6
Subject: Re: [PHP-DEV] Internal Serializable object. Hack to create an object
 without constructor
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a113a73a2e9b6af04fbc6e7b6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 12, 2014 at 1:48 PM, Remi Collet <remi@fedoraproject.org> wrote=
:

> Hi,
>
> As Internal Class doesn't support newInstanceWithoutConstructor, some
> user code use the above hack (ex phpunit-mock-object)
>
> $object =3D unserialize(
>   sprintf('%s:%d:"%s":0:{}',
>     (version_compare(PHP_VERSION, '5.4', '>')
>        && $class->implementsInterface("Serializable") ? "C" : "O"),
>     strlen($className),
>     $className
>   )
> );
>
> Of course, this is already a hack.
>
> Of course, better solution will be to support
> newInstanceWithoutConstructor for all internals classes, but this is
> another story
>
> Problem, Serializable internal class raised the
> 'Empty serialized string cannot be empty' exception.
>
> I don't really see any reason to make serialized string mandatory, as
> those classes can be create (constructor) without any mandatory option.
>
> The trivial attached patch could make everyone life easier.
>
> The new test serialize again the result object to ensure all internal
> structures are properly initialized, and no segfault.
>
>
> Feedback welcome.
>
>
> Remi.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

I'm +1 on this change, would like to hear what others think.

ps: small typo in the patch:
Check that SplObjectStorage::unserialize desn't throws exception when NULL
passed
should be
Check that SplObjectStorage::unserialize doesn't throw exception when NULL
passed
imo

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a113a73a2e9b6af04fbc6e7b6--