Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74866
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.196 cause and error)
Message-ID: <539992AC.3070200@fedoraproject.org>
Date: Thu, 12 Jun 2014 13:44:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
CC: Sebastian Bergmann <sebastian@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Internal Serializable object. Hack to create an object without constructor
From: remi@fedoraproject.org (Remi Collet)

Hi,

As Internal Class doesn't support newInstanceWithoutConstructor, some
user code use the above hack (ex phpunit-mock-object)

$object =3D unserialize(
  sprintf('%s:%d:"%s":0:{}',
    (version_compare(PHP_VERSION, '5.4', '>')
       && $class->implementsInterface("Serializable") ? "C" : "O"),
    strlen($className),
    $className
  )
);

Of course, this is already a hack.

Of course, better solution will be to support
newInstanceWithoutConstructor for all internals classes, but this is
another story

Problem, Serializable internal class raised the
'Empty serialized string cannot be empty' exception.

I don't really see any reason to make serialized string mandatory, as
those classes can be create (constructor) without any mandatory option.

The trivial attached patch could make everyone life easier.

The new test serialize again the result object to ensure all internal
structures are properly initialized, and no segfault.


Feedback welcome.


Remi.