Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74864 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79605 invoked from network); 12 Jun 2014 09:03:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jun 2014 09:03:43 -0000 Authentication-Results: pb1.pair.com smtp.mail=ajf@ajf.me; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ajf@ajf.me; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ajf.me designates 198.187.29.248 as permitted sender) X-PHP-List-Original-Sender: ajf@ajf.me X-Host-Fingerprint: 198.187.29.248 imap7-3.ox.privateemail.com Received: from [198.187.29.248] ([198.187.29.248:45442] helo=imap7-3.ox.privateemail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6A/11-02977-DEC69935 for ; Thu, 12 Jun 2014 05:03:42 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.privateemail.com (Postfix) with ESMTP id CC5CD6038B; Thu, 12 Jun 2014 05:03:38 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at imap7.ox.privateemail.com Received: from mail.privateemail.com ([127.0.0.1]) by localhost (imap1.ox.privateemail.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IGzNT430NqwG; Thu, 12 Jun 2014 05:03:38 -0400 (EDT) Received: from [192.168.0.200] (unknown [90.203.28.11]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.privateemail.com (Postfix) with ESMTPSA id 5CDCB60388; Thu, 12 Jun 2014 05:03:36 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) In-Reply-To: <20140612052801.GA456@scalar.divbyzero.net> Date: Thu, 12 Jun 2014 10:03:33 +0100 Cc: internals@lists.php.net Content-Transfer-Encoding: quoted-printable Message-ID: References: <20140612052801.GA456@scalar.divbyzero.net> To: Martin Jansen X-Mailer: Apple Mail (2.1878.2) Subject: Re: [PHP-DEV] PR 664: Streamlining of cookie handling in ext/session and setcookie From: ajf@ajf.me (Andrea Faulds) On 12 Jun 2014, at 06:28, Martin Jansen wrote: > About a month ago I've submitted PR 644 to GitHub. The contained = patch > unifies the cookie handling in ext/session and setcookie() so we get > consistent Set-Cookie headers in our HTTP responses. >=20 > https://github.com/php/php-src/pull/664 >=20 > It looks like the PR fell of the radar due to the ongoing phpng = efforts. > What do you think? Looks good. I=92ve merged it. :) -- Andrea Faulds http://ajf.me/