Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74827 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19130 invoked from network); 10 Jun 2014 17:45:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2014 17:45:32 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.192.181 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.192.181 mail-pd0-f181.google.com Received: from [209.85.192.181] ([209.85.192.181:45679] helo=mail-pd0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 07/3E-42235-A3447935 for ; Tue, 10 Jun 2014 13:45:31 -0400 Received: by mail-pd0-f181.google.com with SMTP id z10so6251236pdj.26 for ; Tue, 10 Jun 2014 10:45:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4OhwHwFfSOkq37ozassyMvnggO2P/l7E5pJsQur9bYc=; b=V6WxdO8PlyGgkMK3+ld9tmDZ++6TpgFsxQ6XljogFZysHcG5ZOqCYnXW4AiBmUoXIm rBx+LvEGhZhU1XT6aGWN/fNn1w+vyn2eZiQr2UHq3UoAdIPaHRP037jj+bmtAuEapvVl HGqJWRSspKLTw0Xs8hMlSXlc8CqpJf5CGQcvFJjxPSHMv68FINAV+gUIcN6IGRBZbWiK pNEAn+hkkO7XN4fKImxNLc6VEvtjBMVQtxt1nnF+5D9zjqYPnGNW5FztDIZykyPbPQsg +7esmowxtLYDXlbUyoY4Zjy+ganPxP6IsY3SwKfY1WNNqqhXmKJzj/vxXVkDRzHnjchj MjgA== X-Gm-Message-State: ALoCoQkyTcvu41Qi+6fuWy4JV7T3qcYHAkibndsZo0161/xcO2ET7nfEom8jrQTStksKTXKaaAaQ MIME-Version: 1.0 X-Received: by 10.66.122.70 with SMTP id lq6mr7009928pab.51.1402422328429; Tue, 10 Jun 2014 10:45:28 -0700 (PDT) Sender: php@golemon.com Received: by 10.70.100.67 with HTTP; Tue, 10 Jun 2014 10:45:28 -0700 (PDT) X-Originating-IP: [2620:0:1cfe:18:22c9:d0ff:fe87:295b] In-Reply-To: References: Date: Tue, 10 Jun 2014 10:45:28 -0700 X-Google-Sender-Auth: fcZixxzXYkhSQASYjwGiarglRe0 Message-ID: To: Derick Rethans Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC] ReflectionParameter::hasTypehint() / getTypehintText() From: pollita@php.net (Sara Golemon) On Mon, Jun 9, 2014 at 7:47 AM, Derick Rethans wrote: > On Thu, 29 May 2014, Sara Golemon wrote: >> Pretty straight-forward. Makes it easier to recreate a function >> signature from PHP (Mocking) >> https://wiki.php.net/rfc/reflectionparameter.typehint > > On your updated proposal, there is a comment on how class names should > be returned. Right now, the test case only tests for "StdClass", but I > also think you should have a look at namespaced classes, and full > qualified class names in tests. I think that might show class names > should be returned with a \ in front of it. > Nice catch, I'll integrate that after Levi has finished with his return type hinting rfc (we agreed to get his bit done first, then I'll rebase my reflection stuff onto it) -Sara