Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74760 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 11982 invoked from network); 5 Jun 2014 18:08:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Jun 2014 18:08:15 -0000 Authentication-Results: pb1.pair.com header.from=nlopess@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=nlopess@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 212.55.154.21 as permitted sender) X-PHP-List-Original-Sender: nlopess@php.net X-Host-Fingerprint: 212.55.154.21 relay1.ptmail.sapo.pt Linux 2.4/2.6 Received: from [212.55.154.21] ([212.55.154.21:56268] helo=sapo.pt) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 80/00-11934-D02B0935 for ; Thu, 05 Jun 2014 14:08:15 -0400 Received: (qmail 2471 invoked from network); 5 Jun 2014 18:08:09 -0000 Received: from unknown (HELO sapo.pt) (10.134.36.75) by relay1 with SMTP; 5 Jun 2014 18:08:09 -0000 Received: (qmail 13337 invoked from network); 5 Jun 2014 18:08:09 -0000 Received: from unknown (HELO pc07654) (nunoplopes@sapo.pt@[85.244.9.63]) (envelope-sender ) by mta-auth01 (qmail-ptmail-1.0.0) with SMTP for ; 5 Jun 2014 18:08:04 -0000 X-PTMail-RemoteIP: 85.244.9.63 X-PTMail-AllowedSender-Action: Message-ID: <8305622955BF49F18659A0CACD51E1DA@pc07654> To: "Ferenc Kovacs" , "Nicolai Scheer" Cc: "PHP Internals" References: In-Reply-To: Date: Thu, 5 Jun 2014 19:08:03 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Windows Mail 6.0.6002.18197 X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6002.18463 Subject: Re: [PHP-DEV] tests code coverage for php 5.5 From: nlopess@php.net ("Nuno Lopes") >> Hi, >> >> looking for tasks to invest a little spare time in the weeks to come I >> had >> a look at >> >> http://gcov.php.net/viewer.php?version=PHP_5_5 >> >> The test coverage is suspiciously low... >> >> Test coverage of 5.4 is quite high, so is coverage for 5.3. >> >> I would have guessed, that for a new major php version all tests from the >> previous version are reused, and fixed if needed. >> >> Looking at the 5.5 source tree all the phpt files seem in place... Aren't >> the tests just currently not executed on gcov.php.net? >> >> Thanks for any insight! >> >> Greetings >> >> Nico >> > > Yeah, something is definitely wrong: > http://gcov.php.net/PHP_5_4/lcov_html/ > vs > http://gcov.php.net/PHP_5_5/lcov_html/ > > and it we dates are correct, the last gcov build for 5.6 was more than a > week ago: > http://gcov.php.net/ > http://gcov.php.net/PHP_5_6/lcov_html/ > > ps: I've cc'ed Nuno as he is the man who knows our gcov setup. Thanks for CC'ing me. Short version: the problem is fixed. The next round of builds will have correct coverage data (including PHP_HEAD that will be available within a few hours). Long version: There was a bug in the makefile that was triggered when the Zend opcode cache was commited. A few days ago I tried to fix it, but ended up introducing another bug. Anyway, I believe my last commit fixed the problem in Makefile.gcov, and therefore the next round of builds should finally have correct data. Nuno P.S.: BTW, regarding the existence of gcov.php.net, when it was created there were no off-the-shelf solutions, and therefore we created our own. It's not awsome, but works fine. Of course I'm fine with killing it when a replacement becomes available.