Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74729 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32360 invoked from network); 3 Jun 2014 19:05:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jun 2014 19:05:11 -0000 Authentication-Results: pb1.pair.com smtp.mail=jmikola@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=jmikola@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.179 as permitted sender) X-PHP-List-Original-Sender: jmikola@gmail.com X-Host-Fingerprint: 209.85.128.179 mail-ve0-f179.google.com Received: from [209.85.128.179] ([209.85.128.179:57968] helo=mail-ve0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 78/7C-64944-66C1E835 for ; Tue, 03 Jun 2014 15:05:11 -0400 Received: by mail-ve0-f179.google.com with SMTP id oy12so7422007veb.24 for ; Tue, 03 Jun 2014 12:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KDSvd++KLkHnstarXI8rimiqepMD2PkZUFbR4GG4xjU=; b=odVUn3VG6geAo1oLaqBs6WkLJmkM4myvfY4gXR7IUQ2UKJAyDqnhis/WxfYqC4mD95 wXWc4Q9j24nSb1aeS2xjI5zK53zCo+gymMyKURlYbWW+U2jsNvLKg1TtTX/jD5F7ST88 QEBPMoqIerR7CRqHtFUDOHc+6odS20CcuLuYwxmhGGj+/5IWzrRdyIpHO7kz5l42ILQV qdN8DPfLVs2wNXaGNdJcItpqlttX1Un4+Ri+TLRwgS3kHDStoGJHhVr7LlDl9cBge+H8 8UUu+LTPlFdgbLNUBeXjEO+mkFWyCQ2+3n4vq9ikn6CHeF17DvQ5PVUEjx+ZXQk/ZYvJ mCKA== X-Received: by 10.220.175.70 with SMTP id w6mr3224461vcz.72.1401822308032; Tue, 03 Jun 2014 12:05:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.176.199 with HTTP; Tue, 3 Jun 2014 12:04:47 -0700 (PDT) In-Reply-To: References: <53886F73.70402@php.net> <1401810913.2282.81.camel@guybrush> <538DFEB1.7030207@fedoraproject.org> Date: Tue, 3 Jun 2014 15:04:47 -0400 Message-ID: To: Marco Pivetta Cc: PHP Internals Content-Type: multipart/alternative; boundary=047d7b3a93e0b5671704faf330f4 Subject: Re: [PHP-DEV] BC break in 5.4.29 and 5.5.13 From: jmikola@gmail.com (Jeremy Mikola) --047d7b3a93e0b5671704faf330f4 Content-Type: text/plain; charset=UTF-8 On Tue, Jun 3, 2014 at 1:11 PM, Marco Pivetta wrote: > > It is going to be released, but yes, we actually have the expectation a > patch release for 5.4 and 5.5 with a rollback of this breakage. The original Doctrine PR that fixed this issue was https://github.com/doctrine/doctrine2/pull/1045, and Benjamin made some revisions in https://github.com/doctrine/doctrine2/commit/e577e7786796e9393df381f02221046dea6253a5 (note: there is a typo there, as he actually should be checking for 5.4.29 instead of 5.4.28). Based on the conversation above, it sounds like the revert will end up in 5.4.30 and 5.5.14, but we should expect the change for 5.6+. In that case, Benjamin's commit needs to (a) fix the 5.4.x typo and (b) add another condition to utilize Reflection for 5.6+. Has PHPUnit already incorporated a work-around for this? At a glance, I didn't see anything in the main repository or https://github.com/sebastianbergmann/phpunit-mock-objects. -- jeremy mikola --047d7b3a93e0b5671704faf330f4--