Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74711 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95465 invoked from network); 3 Jun 2014 13:28:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jun 2014 13:28:36 -0000 Authentication-Results: pb1.pair.com header.from=remi@fedoraproject.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=remi@fedoraproject.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.197 cause and error) X-PHP-List-Original-Sender: remi@fedoraproject.org X-Host-Fingerprint: 217.70.183.197 relay5-d.mail.gandi.net Linux 2.6 Received: from [217.70.183.197] ([217.70.183.197:51431] helo=relay5-d.mail.gandi.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 90/A5-64944-28DCD835 for ; Tue, 03 Jun 2014 09:28:35 -0400 Received: from mfilter24-d.gandi.net (mfilter24-d.gandi.net [217.70.178.152]) by relay5-d.mail.gandi.net (Postfix) with ESMTP id F1D8341C07D for ; Tue, 3 Jun 2014 15:28:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter24-d.gandi.net Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by mfilter24-d.gandi.net (mfilter24-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id WPID91vEf6y8 for ; Tue, 3 Jun 2014 15:28:30 +0200 (CEST) X-Originating-IP: 82.241.130.121 Received: from schrodingerscat.famillecollet.com (pom51-2-82-241-130-121.fbx.proxad.net [82.241.130.121]) (Authenticated sender: contact@ll-experts.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 108A741C09E for ; Tue, 3 Jun 2014 15:28:29 +0200 (CEST) Message-ID: <538DCD7C.2050707@fedoraproject.org> Date: Tue, 03 Jun 2014 15:28:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: PHP Internals References: <53886F73.70402@php.net> <5388893B.6080305@php.net> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Re: BC break in 5.4.29 and 5.5.13 From: remi@fedoraproject.org (Remi Collet) Le 03/06/2014 14:41, Anatol Belski a =C3=A9crit : > I've invented a patch fixing BC regarding this issue. Tested. Work fine. Thanks. > It passes the > userspace classes but blocks the internal classes. While it's a must fo= r > the stable 5.4 and 5.5,=20 Strongly agree. > I still doubt we should put it into 5.6++. Even it > can work with userspace classes, it's highly inconsistent. For example = - a > userclass implementing Serializable but throwing an exception in > unserialize() will behave wrong when instantiated that way. >=20 > Basically before I apply this fix - IMHO, it should go into 5.4 and 5.5 > only, 5.6 should have clean behaviour.=20 Agree. Remi. > From the userspace perspective - > doctrine and phpunit have already fixed this using > ReflectionClass::newInstanceWithoutConstructor(), so that is fine with = the > future. The fix should only go for legacy. So, what you say? >=20 > Regards >=20 > Anatol >=20 >=20