Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74703
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <537E65B6.3060205@gmail.com>
References: <537E65B6.3060205@gmail.com>
Date: Tue, 3 Jun 2014 09:46:19 +0200
Message-ID: <CAH-PCH5S51yV6cCYAywK9Q2N_HBQ_xP_pjL+P3qT2o1YZTrEGQ@mail.gmail.com>
To: Gary Mort <garyamort@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113a84d2175d1904fae9b572
Subject: Re: [PHP-DEV] filter_input and auto_globals_jit
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a113a84d2175d1904fae9b572
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, May 22, 2014 at 11:01 PM, Gary Mort <garyamort@gmail.com> wrote:

> Here is an oddity which I'm not sure how this is supposed to work.
>
> If you have auto_globals_jit enables then not only are super global
> variables not initialized unless they are called, the underlying data
> storage for the original data[used by filter_input] will not be populated=
.
>
> As I read filter.c, there seems to be a weird schism on how it deals with
> this.
> https://github.com/php/php-src/blob/master/ext/filter/filter.c#L526
>
> For INPUT_SERVER and INPUT_ENV it seems as if filter will make sure to
> initialize the data, example:
>         if (PG(auto_globals_jit)) {
>                                 zend_is_auto_global("_SERVER",
> sizeof("_SERVER")-1 TSRMLS_CC);
>                         }
>
> For INPUT_POST, INPUT_GET, and INPUT_COOKIE however there is no safety ne=
t.
>
> For example, with Just in Time:
> test.php?var=3Dtest
>
> $before =3D filter_input(INPUT_GET);  // $before =3D null
> $var =3D $_GET('test');           // $var =3D 'test'
> $after =3D filter_input(INPUT_GET);       // $after =3D 'test'
>
>
> So the question is, is this by design?  In which case I'll update the
> docs.  Or is this an oversight?  In which case I'll open a bug and submit=
 a
> patch.
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
could you fill a bug at https://bugs.php.net/ ?

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a113a84d2175d1904fae9b572--