Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74656 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90695 invoked from network); 30 May 2014 14:26:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 May 2014 14:26:06 -0000 Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:39747] helo=klapt.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B6/5C-07154-AF498835 for ; Fri, 30 May 2014 10:26:03 -0400 Received: by klapt.com (Postfix, from userid 33) id 6C67C6D2009; Fri, 30 May 2014 16:25:59 +0200 (CEST) Received: from 178.2.29.37 (SquirrelMail authenticated user anatol@belski.net) by webmail.klapt.com with HTTP; Fri, 30 May 2014 16:25:59 +0200 Message-ID: In-Reply-To: <5388893B.6080305@php.net> References: <53886F73.70402@php.net> <5388893B.6080305@php.net> Date: Fri, 30 May 2014 16:25:59 +0200 To: "Remi Collet" Cc: "PHP" User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Re: BC break in 5.4.29 and 5.5.13 From: anatol.php@belski.net ("Anatol Belski") Hi Remi, On Fri, May 30, 2014 15:35, Remi Collet wrote: > Le 30/05/2014 13:45, Remi Collet a écrit : > >> Hi. >> >> >> Following http://news.php.net/php.internals/73957 >> >> >> This change breaks at least doctrine and phpunit. >> >> >> Source code: >> >> > https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mappin > g /ClassMetadataInfo.php#L911 > > > Fixed in doctrine > > > https://github.com/doctrine/doctrine2/commit/93c276d059b40b0783ba9a24549a > 8 > b135e257693#diff-093aaad4da679d0374260757bf7bafca > >> > https://github.com/sebastianbergmann/phpunit-mock-objects/blob/master/src > / > Framework/MockObject/Generator.php#L274 > > > Fix in PHPUnit > > > https://github.com/sebastianbergmann/phpunit-mock-objects/commit/1c68f133 > 8 > f1940deb8265428bb2a7cbc5bc074b5#diff-64dbbc1c21f9be2d92e2b715617ffe34 > > https://github.com/sebastianbergmann/phpunit-mock-objects/commit/1c68f133 > 8 > f1940deb8265428bb2a7cbc5bc074b5#diff-64dbbc1c21f9be2d92e2b715617ffe34 > > thanks for the reproduce case. As discussed on the IRC, I'll be working on a solution to minimize the BC break in 5.4 and 5.5. IMHO 5.6 is fine with that "as is", as it's correct with the current specifications of the Serializable and fixes wide range crash vulnerability. Regards Anatol