Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74654 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81826 invoked from network); 30 May 2014 11:46:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 May 2014 11:46:04 -0000 Authentication-Results: pb1.pair.com header.from=remi@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=remi@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 209.132.183.28 as permitted sender) X-PHP-List-Original-Sender: remi@php.net X-Host-Fingerprint: 209.132.183.28 mx1.redhat.com Received: from [209.132.183.28] ([209.132.183.28:17097] helo=mx1.redhat.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/5B-07154-87F68835 for ; Fri, 30 May 2014 07:46:02 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4UBjv15024715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 30 May 2014 07:45:58 -0400 Received: from laptop.rcollet.redhat.com (vpn1-5-49.ams2.redhat.com [10.36.5.49]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4UBjthU015012 for ; Fri, 30 May 2014 07:45:56 -0400 Message-ID: <53886F73.70402@php.net> Date: Fri, 30 May 2014 13:45:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: PHP Content-Type: multipart/alternative; boundary="------------090707050106040707030606" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Subject: BC break in 5.4.29 and 5.5.13 From: remi@php.net (Remi Collet) --------------090707050106040707030606 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi. Following http://news.php.net/php.internals/73957 This change breaks at least doctrine and phpunit. Source code: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php#L911 https://github.com/sebastianbergmann/phpunit-mock-objects/blob/master/src/Framework/MockObject/Generator.php#L274 Something like, (used to not call __construct) : $object = unserialize(sprintf('O:%d:"%s":0:{}', strlen($className), $className) Big reproducer: # pear channel-discover pear.horde.org # pear install horde/Horde_Test # pear install horde/Horde_Imap_Client # pear download horde/Horde_Imap_Client # tar xf Horde_Imap_Client-2.20.0.tgz # cd Horde_Imap_Client-2.20.0/ # cd test/Horde/Imap/Client/ # wget https://phar.phpunit.de/phpunit.phar # php phpunit.phar . PHPUnit 4.1.0 by Sebastian Bergmann. Configuration read from /root/Horde_Imap_Client-2.20.0/test/Horde/Imap/Client/phpunit.xml ...............EEEEEEEEEEEEEEEEEEEEEEEEEEEE.................... 63 / 211 ( 29%) .................................FF............................ 126 / 211 ( 59%) SS............................................................. 189 / 211 ( 89%) ...................... Time: 1.07 seconds, Memory: 18.50Mb There were 28 errors: 1) Horde_Imap_Client_Cache_CacheTest::testGet Erroneous data format for unserializing 'Mock_Horde_Imap_Client_Socket_1e0b6300' /root/Horde_Imap_Client-2.20.0/test/Horde/Imap/Client/Cache/TestBase.php:36 phar:///root/Horde_Imap_Client-2.20.0/test/Horde/Imap/Client/phpunit.phar/phpunit/TextUI/Command.php:179 phar:///root/Horde_Imap_Client-2.20.0/test/Horde/Imap/Client/phpunit.phar/phpunit/TextUI/Command.php:132 2) Horde_Imap_Client_Cache_CacheTest::testGetCachedUids Erroneous data format for unserializing 'Mock_Horde_Imap_Client_Socket_1e0b6300' .... Remi. --------------090707050106040707030606--