Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74651
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.213.182 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <CAFMT4NreLeoOH-bO1DjPGhjVnyAzYq1cX_O3D9GcRM-V4UW+Kg@mail.gmail.com>
References: <CAESVnVpJGOSH=o4tu4YE7EfseSN2oGyHczovDg44fqto1D-nyA@mail.gmail.com>
 <alpine.DEB.2.10.1405292354040.5108@whisky.home.derickrethans.nl> <CAFMT4NreLeoOH-bO1DjPGhjVnyAzYq1cX_O3D9GcRM-V4UW+Kg@mail.gmail.com>
Date: Thu, 29 May 2014 22:06:03 -0700
Message-ID: <CADajX4A-=9Duzw29U5RHi5W87EjeZWRcaSRQU5RYnfX3YxaQzw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Derick Rethans <derick@php.net>, Sara Golemon <pollita@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] ReflectionParameter::hasTypehint() / getTypehintText()
From: aharvey@php.net (Adam Harvey)

On 29 May 2014 18:08, Levi Morrison <levim@php.net> wrote:
> On Thu, May 29, 2014 at 4:54 PM, Derick Rethans <derick@php.net> wrote:
>> I don't think it should return an empty string when hasTypehint has
>> failed (the 4th "test") in your test case (for $d). IMO, it should
>> return NULL.
>
> If it doesn't have type information I think an empty string should be
> returned. Since you can't have an empty type hint there really isn't a
> conflict there. This means the function can always return a string.

I'd prefer NULL to indicate the complete absence of a type hint too =E2=80=
=94
it ends up as an empty string if it's used in that context regardless,
but the changed type is useful. I don't feel strongly enough about
this that it would affect my vote, though.

> That's my $0.02.

Adam, providing 2.17 Canadian cents.