Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <alpine.DEB.2.10.1405292354040.5108@whisky.home.derickrethans.nl>
References: <CAESVnVpJGOSH=o4tu4YE7EfseSN2oGyHczovDg44fqto1D-nyA@mail.gmail.com>
	<alpine.DEB.2.10.1405292354040.5108@whisky.home.derickrethans.nl>
Date: Thu, 29 May 2014 19:08:41 -0600
Message-ID: <CAFMT4NreLeoOH-bO1DjPGhjVnyAzYq1cX_O3D9GcRM-V4UW+Kg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] ReflectionParameter::hasTypehint() / getTypehintText()
From: levim@php.net (Levi Morrison)

On Thu, May 29, 2014 at 4:54 PM, Derick Rethans <derick@php.net> wrote:
> On Thu, 29 May 2014, Sara Golemon wrote:
>
>> Pretty straight-forward.  Makes it easier to recreate a function
>> signature from PHP (Mocking)
>> https://wiki.php.net/rfc/reflectionparameter.typehint
>
> I don't think it should return an empty string when hasTypehint has
> failed (the 4th "test") in your test case (for $d). IMO, it should
> return NULL.

If it doesn't have type information I think an empty string should be
returned. Since you can't have an empty type hint there really isn't a
conflict there. This means the function can always return a string.

That's my $0.02.