Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74648 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32278 invoked from network); 29 May 2014 22:54:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 May 2014 22:54:53 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:40229] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 79/B4-07154-BBAB7835 for ; Thu, 29 May 2014 18:54:52 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 1271010D9B0; Thu, 29 May 2014 23:54:49 +0100 (BST) Date: Thu, 29 May 2014 23:54:48 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Sara Golemon cc: PHP internals In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] [RFC] ReflectionParameter::hasTypehint() / getTypehintText() From: derick@php.net (Derick Rethans) On Thu, 29 May 2014, Sara Golemon wrote: > Pretty straight-forward. Makes it easier to recreate a function > signature from PHP (Mocking) > https://wiki.php.net/rfc/reflectionparameter.typehint I don't think it should return an empty string when hasTypehint has failed (the 4th "test") in your test case (for $d). IMO, it should return NULL. cheers, Derick