Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74646
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.160.46 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAFMT4NpZPu+ynTeOPKZF__8jUMyyScop4dHQORi_BLs4J5wC3w@mail.gmail.com>
References: <CAESVnVpJGOSH=o4tu4YE7EfseSN2oGyHczovDg44fqto1D-nyA@mail.gmail.com>
	<CAFMT4NpZPu+ynTeOPKZF__8jUMyyScop4dHQORi_BLs4J5wC3w@mail.gmail.com>
Date: Thu, 29 May 2014 15:01:12 -0700
Message-ID: <CAESVnVrc_d7XvwxfJM91ixXkVE2ENjC+SgxzmHtMTvCuqSEA=Q@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] ReflectionParameter::hasTypehint() / getTypehintText()
From: pollita@php.net (Sara Golemon)

On Thu, May 29, 2014 at 1:55 PM, Levi Morrison <morrison.levi@gmail.com> wrote:
> On Thu, May 29, 2014 at 1:59 PM, Sara Golemon <pollita@php.net> wrote:
>> Pretty straight-forward.  Makes it easier to recreate a function
>> signature from PHP (Mocking)
>> https://wiki.php.net/rfc/reflectionparameter.typehint
>
> I'm hoping to improve the way types are handled in reflection but I've
> been waiting until the return types and nullable types RFCs have been
> voted on as that will most likely impact my decisions. I'd like to
> introduce getType and hasType functions that holds various bits of
> information such as isArray(), isCallable() and could also contain the
> text representation of the type. What are your thoughts on that?
>
As in something like this?

$rf = new ReflectionFunction('foo');
list($rp) = $rf->getParameters();
$hint = $rp->getType(); // returns ReflectionTypeHint
if ($hint->isArray()) { ... }

I thought about that (and would like to see it), which is why I
specifically went for the name getTypehintText(), which leaves the
"get me an object version" (i.e. getTypehint()) left available.  See
also: https://wiki.php.net/rfc/reflectionparameter.typehint#on_the_naming
 If you think it's a bit too busy to have getTypehint(): object, and
getTypehintText(): string, I can hold off on this RFC for awhile.
There's certainly no rush.


Or did you mean something else?

-Sara