Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74602
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.44 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <1401282869.2998.84.camel@guybrush>
References: <2DC459EE-AE98-4CAE-977A-6FB918FDEF54@bafford.com>
	<537EA42B.4000000@lerdorf.com>
	<B20CF9D3-B61C-462E-825A-DA421F351694@bafford.com>
	<CAEZPtU7p-RiamfkdmBGGg2ADpqbsmev_SBxT7t60dJ7xWN+5AA@mail.gmail.com>
	<CAMUwpuQ+yy5ZJx_wEgt3S_ZRG2rBOAOciz7YMdYw97Gbqhud9g@mail.gmail.com>
	<alpine.DEB.2.10.1405281239590.5108@whisky.home.derickrethans.nl>
	<CAEKnhAHr_K7j=gm=2HoTJLyHn9ykkQ96DNQa7K7k1rRC7PXsJg@mail.gmail.com>
	<CAEKnhAETqw-eor45nz3Z8zCPZSaF7DA6rG_S9E1d4M+fgkrvVA@mail.gmail.com>
	<1401282869.2998.84.camel@guybrush>
Date: Wed, 28 May 2014 19:39:07 +0100
Message-ID: <CAEKnhAGpuFfi59ChgfkaPr5Fnw0e7ArH_w7eTJ2s8Z9_qHahuw@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Derick Rethans <derick@php.net>, Julien Pauli <jpauli@php.net>, Pierre Joye <pierre.php@gmail.com>, 
	John Bafford <john@bafford.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	PHP internals <internals@lists.php.net>, Ferenc Kovacs <tyrael@php.net>
Content-Type: multipart/alternative; boundary=089e015386a2a937d104fa7a206f
Subject: Re: [PHP-DEV] Bison 3 support for PHP 5.5
From: bukka@php.net (Jakub Zelenka)

--089e015386a2a937d104fa7a206f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, May 28, 2014 at 2:14 PM, Johannes Schl=C3=BCter
<johannes@schlueters.de>wrote:

> On Wed, 2014-05-28 at 14:05 +0100, Jakub Zelenka wrote:
> > Ooops. We don't actaully distribute tab files. Thought that we do... :)
> >
> > Wouldn't be better to add them to the git? What's the actual reason to
> not
> > to add them. The same thing we do for scanner files already. I'm not
> aware
> > that bison would generate some platform specific tab files...?
>
> We don't in git ut snapshots and releases. Git is only for developers.
> Having generated files in version control is questionable as this leads
> to annoyance when timestamps come out wrong they are recreated using a
> different tool version and then are being committed or have conflicts
> "all the time".
>
>
That would make sense if we didn't have re2c generated files in the repo
already. Anyway I see your point. Bison version varies across the systems
more than re2c so the diffs in files would be more often which is not a
good idea...

The solution could be to stick just with one version of bison for people
that want to do changes to the grammar. It should be possible fail the make
phase (not configuration) when the version is different (for example empty
YACC variable when the version is different and then add check to
Makefile.frag or something like that). During the configuration you would
just get a warning. But that's a bit off topic and just an idea that could
be considered only for new major version... :)

Jakub

--089e015386a2a937d104fa7a206f--