Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74572
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.47 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CAEKnhAHr_K7j=gm=2HoTJLyHn9ykkQ96DNQa7K7k1rRC7PXsJg@mail.gmail.com>
References: <2DC459EE-AE98-4CAE-977A-6FB918FDEF54@bafford.com>
	<537EA42B.4000000@lerdorf.com>
	<B20CF9D3-B61C-462E-825A-DA421F351694@bafford.com>
	<CAEZPtU7p-RiamfkdmBGGg2ADpqbsmev_SBxT7t60dJ7xWN+5AA@mail.gmail.com>
	<CAMUwpuQ+yy5ZJx_wEgt3S_ZRG2rBOAOciz7YMdYw97Gbqhud9g@mail.gmail.com>
	<alpine.DEB.2.10.1405281239590.5108@whisky.home.derickrethans.nl>
	<CAEKnhAHr_K7j=gm=2HoTJLyHn9ykkQ96DNQa7K7k1rRC7PXsJg@mail.gmail.com>
Date: Wed, 28 May 2014 14:05:19 +0100
Message-ID: <CAEKnhAETqw-eor45nz3Z8zCPZSaF7DA6rG_S9E1d4M+fgkrvVA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Julien Pauli <jpauli@php.net>, Pierre Joye <pierre.php@gmail.com>, 
	John Bafford <john@bafford.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	PHP internals <internals@lists.php.net>, Ferenc Kovacs <tyrael@php.net>
Content-Type: multipart/alternative; boundary=001a1135086edd22df04fa757673
Subject: Re: [PHP-DEV] Bison 3 support for PHP 5.5
From: bukka@php.net (Jakub Zelenka)

--001a1135086edd22df04fa757673
Content-Type: text/plain; charset=UTF-8

On Wed, May 28, 2014 at 1:56 PM, Jakub Zelenka <bukka@php.net> wrote:

> On Wed, May 28, 2014 at 12:41 PM, Derick Rethans <derick@php.net> wrote:
>
>> On Fri, 23 May 2014, Julien Pauli wrote:
>>
>> > That's a no-go for 5.5.
>> > 5.5 is stable, 1year old (at this email date), and we should not
>> > change such a thing into this stable branch.
>>
>> Right, but it's going to be supported for at least another year. And
>> right now, on the latest Ubuntu's with only bison 3 you can't actually
>> build it. Because of that, a patch like this should absolutely be
>> considered.
>>
>
> Why not just disable checking of bison version in stable versions. We
> distribute generated tab files and there is no point to fail the configure
> step just because someone cannot create tab file. The bison is used only if
> the *.y files are changed. The thing is that such change is not allowed for
> stable branches anyway. In case someone really wants to play with grammar
> on old branches, then he/she should be able to install a correct version of
> bison. But I think that we can count number of such users on one hand.
>
> Just disabling version check is only config change and should not be a
> problem for stable branches IMHO.
>
> We can add a proper support for bison3 to phpng. The current patch seems
> to me more like a hack than a proper solution...
>
> Thoughts?
>
> Jakub
>


Ooops. We don't actaully distribute tab files. Thought that we do... :)

Wouldn't be better to add them to the git? What's the actual reason to not
to add them. The same thing we do for scanner files already. I'm not aware
that bison would generate some platform specific tab files...?

Regards

Jakub

--001a1135086edd22df04fa757673--