Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:74515 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89692 invoked from network); 27 May 2014 06:23:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 May 2014 06:23:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.45 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.45 mail-qg0-f45.google.com Received: from [209.85.192.45] ([209.85.192.45:36360] helo=mail-qg0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 77/00-23621-25F24835 for ; Tue, 27 May 2014 02:23:14 -0400 Received: by mail-qg0-f45.google.com with SMTP id z60so13247084qgd.32 for ; Mon, 26 May 2014 23:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=V51BV367y6D2D2FB4aRFkXGxoU0inX+1w/pJa/ud35k=; b=TFzlHxq0xy2HgA1/oXN2AU3+HWNWqzJjKxbpu17niF7HC2CwfEqcfH86IYUfzmlFbW 7DOJKX9SCRg8gsg21+KS+m+/jjVcyTR6i8tZoRZ7cTJFDAU26rAjI5xIvoVJfRVrO/xu VLKAbEYe00Xpdt7DHTzkoy0r/6aNxBKpYgXBwYeDFskmEL6wOYF0ss9Pra1Ll4hjkHe7 9Kr/zEMP7sAI4t0Yb3Nf/gLVQd2AVxMKkri3nVV8Ru5X03wGYq7d9qH/ScrtHiXBQpeX kyjLCh/mX/iHgLhA7uBDvIa+5RWi9eJlABEVYZUsTP9aiKY7Qv9sUdK0eZ1xksW2otnP PvWA== MIME-Version: 1.0 X-Received: by 10.140.104.44 with SMTP id z41mr37387683qge.76.1401171447623; Mon, 26 May 2014 23:17:27 -0700 (PDT) Received: by 10.140.47.231 with HTTP; Mon, 26 May 2014 23:17:27 -0700 (PDT) In-Reply-To: <5383F1AE.1090406@sugarcrm.com> References: <-6285448086228171932@unknownmsgid> <67d97efff27b61e45ef74d4f4339b4b3@mail.gmail.com> <962B3020-200F-45D2-8FEC-AD7A0BFDA50E@ajf.me> <5383F1AE.1090406@sugarcrm.com> Date: Tue, 27 May 2014 08:17:27 +0200 Message-ID: To: Stas Malyshev Cc: Bob Weinand , Andrea Faulds , Dmitry Stogov , Zeev Suraski , Xinchen Hui , PHP Internals , Andi Gutmans , Nikita Popov Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] RE: [RFC] Fast Parameter Parsing API From: pierre.php@gmail.com (Pierre Joye) On Tue, May 27, 2014 at 4:00 AM, Stas Malyshev wrote: > Hi! > >> No. You might want to return false (it's maybe not a good idea to do so, but it would break BC to remove that possibility) > > I think we need to use this opportunity to clean up our APIs. I.e. if > the functions return NULL when passed wrong parameters (which makes > sense), then *all* functions should do that, not just 99%, and random 1% > would return something else. > Yes, this means some (very minor) BC issues. We're doing a major > version, and I think this is acceptable price to pay for consistent API. I fully agree here. I would like to do the same with the quiet option, which is not that useful anyway. Btw, I did not check every function, but variable # of arguments seem to be far less used than fixed amount, that could open a door for a special case. Cheers, -- Pierre @pierrejoye | http://www.libgd.org