Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74510
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.176 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <5383F329.3050106@sugarcrm.com>
References: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
 <CABBJUpcNL67-cXyBd=yuWdhZPmHM592Q4-g2PGcyOTS_KsBaqQ@mail.gmail.com>
 <CA+9eiLvj5GVNQ=1D2=RbenfUCUAPaG3uP5H+yAW=TKd-jEVyjw@mail.gmail.com>
 <-6285448086228171932@unknownmsgid> <CA+9eiLvUeu0j+sPz-EWeq4VC=Spzc7tseAp4VHqpiFEaxHdLiQ@mail.gmail.com>
 <67d97efff27b61e45ef74d4f4339b4b3@mail.gmail.com> <962B3020-200F-45D2-8FEC-AD7A0BFDA50E@ajf.me>
 <CA+9eiLu7CZwEFS0bRHCdW2+ScnfuCbo+FCT-8HymLm=WZBhfhA@mail.gmail.com>
 <D1C446F2-C46C-49C1-B66E-702CA4901F1D@ajf.me> <DUB406-EAS3560576E7F9AB9B54837717E23B0@phx.gbl>
 <CAEZPtU4K-y8raOxzL_nkA0p-_3AXZERmcWRBDqnDM6ikNE8c+g@mail.gmail.com> <5383F329.3050106@sugarcrm.com>
Date: Tue, 27 May 2014 10:35:18 +0800
Message-ID: <CABBJUpf7xofMyMY+wpjU-fL1s4wEMfQ9GcURD4zvs-0LkafVgw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Pierre Joye <pierre.php@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, 
	Andrea Faulds <ajf@ajf.me>, Dmitry Stogov <dmitry@zend.com>, Zeev Suraski <zeev@zend.com>, 
	PHP Internals <internals@lists.php.net>, Andi Gutmans <andi@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RE: [RFC] Fast Parameter Parsing API
From: xinchen.h@zend.com (Xinchen Hui)

Hey:
   Sorry for top post, first.

   I am going to talk about a thought I have..

   we can reuse the arginfo as the only key struct for function
arguments declaration/parsing..

   something like, take strlen as example:

declaring:
   ZEND_ARG_INFO(strlen_arginfo, 0, 0, 1)
       Z_ARG_STR()
   ZEND_ARG_INFO_END();

 then when doing  register internal function. Zend vm will bind the Z_ARG_STR to

     int num_args = 0;
     (zend_internl_functions
*)(strlen_function)->argument_handlers[num_args++] =
zend_parse_parameter_str;

the zend_parse_parameter_str here is the handler only handling with
str(which will be effective)

then while in zif_strlen(), only needs call :

     zend_string *str;
     zend_parser_parameters(stren_arginfo, &str);


 the only thing I am not sure now is,  if there are more than 1
arguments of one function, let's say it's 5..

      this implementation will doing 5 functions call.....  which
maybe slower than previous zend_parse_parameter

      thoughts?

thanks

On Tue, May 27, 2014 at 10:06 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> zpp current usage is much more readable to me and less error prone
>> while writing (clang plugin helping to check the syntax, see Johannes
>> tools).
>
> Not really - I have to go to the docs each time to remember what \ or /
> are and what is the difference between H and h or z and Z. And putting a
> wrong arg type is extremely easy. I've just learned about clang thing
> this month, so I'm pretty sure I can count number of people who use it
> on one hand, and it doesn't seem to be mentioned anywhere in the docs.
>
>> May I point you to my questions in this thread about extending the
>> reflection struct, add the necessary info (types) and maybe do the
>> naming args while being at it?
>
> This would be great (again, laying ground for named args support) but
> I'm not sure how to do it. We have a bit of a contradiction here since
> the speedup requires unrolled code (that's what the current ideas do)
> and reflection requires static data struct. I'm not sure how to make
> both work. Maybe with some kind of function pointers in the data struct
> for parsing? But I'm afraid then it would lose the speedup, since it
> won't be inlined unrolled code anymore.
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227



-- 
Xinchen Hui  Laruence
Consultant    at   Zend
http://www.laruence.com/