Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74494
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.220.182 cause and error)
MIME-Version: 1.0
In-Reply-To: <AA4ACAB4-31BC-46BB-933C-10B8939D27C8@ajf.me>
References: <CA+9eiLuknJ7am5jU4WBN7fGXUcZtbb6axsji8ZnydCJ4P-O9hw@mail.gmail.com>
	<CABBJUpcNL67-cXyBd=yuWdhZPmHM592Q4-g2PGcyOTS_KsBaqQ@mail.gmail.com>
	<CA+9eiLvj5GVNQ=1D2=RbenfUCUAPaG3uP5H+yAW=TKd-jEVyjw@mail.gmail.com>
	<-6285448086228171932@unknownmsgid>
	<CA+9eiLvUeu0j+sPz-EWeq4VC=Spzc7tseAp4VHqpiFEaxHdLiQ@mail.gmail.com>
	<67d97efff27b61e45ef74d4f4339b4b3@mail.gmail.com>
	<962B3020-200F-45D2-8FEC-AD7A0BFDA50E@ajf.me>
	<CA+9eiLu7CZwEFS0bRHCdW2+ScnfuCbo+FCT-8HymLm=WZBhfhA@mail.gmail.com>
	<D1C446F2-C46C-49C1-B66E-702CA4901F1D@ajf.me>
	<DUB406-EAS3560576E7F9AB9B54837717E23B0@phx.gbl>
	<AA4ACAB4-31BC-46BB-933C-10B8939D27C8@ajf.me>
Date: Mon, 26 May 2014 13:50:54 +0400
Message-ID: <CA+9eiLuWyVMktR07D0jOXa+RZhVv3n7FoDVnFDSfi8xJuhqi6g@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Bob Weinand <bobwei9@hotmail.com>, Zeev Suraski <zeev@zend.com>, Xinchen Hui <xinchen.h@zend.com>, 
	PHP Internals <internals@lists.php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Andi Gutmans <andi@zend.com>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=bcaec51b97b3e90e9b04fa4a8325
Subject: Re: [PHP-DEV] RE: [RFC] Fast Parameter Parsing API
From: dmitry@zend.com (Dmitry Stogov)

--bcaec51b97b3e90e9b04fa4a8325
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Bob proved that his solution and syntax may work. If people think it's
better, we may adopt RFC.
As you see we don't have complete agreement even between two authors :)
Of course we will take the best (e.g. return removing and compile-time type
checking) from existing proposal as well.
The existing patch might be changed quite easy to support a bit different
syntax.

Thanks. Dmitry.


On Mon, May 26, 2014 at 1:41 PM, Andrea Faulds <ajf@ajf.me> wrote:

>
> On 26 May 2014, at 10:39, Bob Weinand <bobwei9@hotmail.com> wrote:
>
> > ZEND_PARSE_PARAMETERS(ZP_ARRAY(input) ZP_LONG(offset) ZP_OPTIONAL
> ZP_ZVAL(z_length) ZP_BOOL(preserve_keys), { return; })
> > (The return at the end is the error branch)
>
> Why do you need { return; } at the end? Can=E2=80=99t you put that into t=
he
> macro=E2=80=99s definition?
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>

--bcaec51b97b3e90e9b04fa4a8325--